Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 530963002: Move IDS_LEARN_MORE to components_strings.grd (Closed)

Created:
6 years, 3 months ago by hashimoto
Modified:
6 years, 3 months ago
Reviewers:
sky, blundell
CC:
chromium-reviews, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, zea+watch_chromium.org, posciak+watch_chromium.org, browser-components-watch_chromium.org, stuartmorgan+watch_chromium.org, dmazzoni+watch_chromium.org, native-client-reviews_googlegroups.com, stevenjb+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, benquan, Ilya Sherman, jam, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, dtseng+watch_chromium.org, haitaol+watch_chromium.org, yuzo+watch_chromium.org, dkrahn+watch_chromium.org, feature-media-reviews_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org, plundblad+watch_chromium.org, tfarina, mcasas+watch_chromium.org, aboxhall+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, wjia+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move IDS_LEARN_MORE to components_strings.grd To componentize sad_tab related code, move IDS_LEARN_MORE to outside of chrome. BUG=402485 TBR=sky@chromium.org for include fix under chrome/browser Committed: https://crrev.com/a804d98340be56cb3fa7c8c861dca47e47d1b8d8 Cr-Commit-Position: refs/heads/master@{#292908}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -5 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_dialog.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_display.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/dev_mode_bubble_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/ntp_overridden_bubble_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/proxy_overridden_bubble_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/settings_api_bubble_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/suspicious_extension_bubble_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gpu/three_d_api_observer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/infobars/insecure_content_infobar_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/media_stream_infobar_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/nacl_host/nacl_infobar_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/pepper_broker_infobar_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_context_menu/spelling_bubble_model.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/autofill/generated_credit_card_bubble_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_view_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/ui_localizer.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/extensions/extension_install_ui_default.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/startup/google_api_keys_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/accessibility/invert_bubble_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/first_run_dialog.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/network_profile_bubble_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/sad_tab_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/conflicts_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/automatic_settings_reset_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/core_options_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_strings.grd View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
hashimoto
6 years, 3 months ago (2014-09-02 08:40:50 UTC) #2
blundell
lgtm
6 years, 3 months ago (2014-09-02 08:43:28 UTC) #3
hashimoto
TBRing sky@chromium.org for include fix under chrome/browser
6 years, 3 months ago (2014-09-02 08:53:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/530963002/20001
6 years, 3 months ago (2014-09-02 08:53:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/530963002/40001
6 years, 3 months ago (2014-09-02 09:06:12 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 3 months ago (2014-09-02 10:01:00 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 7f45c7e3f0e086761620bafa041c0cc05185855d
6 years, 3 months ago (2014-09-02 10:37:13 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:17:59 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a804d98340be56cb3fa7c8c861dca47e47d1b8d8
Cr-Commit-Position: refs/heads/master@{#292908}

Powered by Google App Engine
This is Rietveld 408576698