MacViews: Implement NativeViewHostMac (take 3)

ui/views/controls/native/native_view_host_aura_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/native/native_view_host_aura.h"
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/window.h"
 #include "ui/base/cursor/cursor.h"
 #include "ui/views/controls/native/native_view_host.h"
-#include "ui/views/test/views_test_base.h"
+#include "ui/views/controls/native/native_view_host_test_base.h"
 #include "ui/views/view.h"
 #include "ui/views/view_constants_aura.h"
 #include "ui/views/widget/widget.h"
 
 namespace views {
 
-// Testing wrapper of the NativeViewHost
-class NativeViewHostTesting : public NativeViewHost {
- public:
-  NativeViewHostTesting() {}
-  virtual ~NativeViewHostTesting() { destroyed_count_++; }
-
-  static void ResetDestroyedCount() { destroyed_count_ = 0; }
-
-  static int destroyed_count() { return destroyed_count_; }
-
- private:
-  static int destroyed_count_;
-
-  DISALLOW_COPY_AND_ASSIGN(NativeViewHostTesting);
-};
-int NativeViewHostTesting::destroyed_count_ = 0;
-
 // Observer watching for window visibility and bounds change events. This is
 // used to verify that the child and clipping window operations are done in the
 // right order.
 class NativeViewHostWindowObserver : public aura::WindowObserver {
  public:
   enum EventType {
     EVENT_NONE,
     EVENT_SHOWN,
     EVENT_HIDDEN,
     EVENT_BOUNDS_CHANGED,
@@ skipping 37 matching lines @@
     events_.push_back(event);
   }
 
  private:
   std::vector<EventDetails> events_;
   gfx::Rect bounds_at_visibility_changed_;
 
   DISALLOW_COPY_AND_ASSIGN(NativeViewHostWindowObserver);
 };
 
-class NativeViewHostAuraTest : public ViewsTestBase {
+class NativeViewHostAuraTest : public test::NativeViewHostTestBase {
  public:
   NativeViewHostAuraTest() {
   }
 
   NativeViewHostAura* native_host() {
-    return static_cast<NativeViewHostAura*>(host_->native_wrapper_.get());
-  }
-
-  Widget* toplevel() {
-    return toplevel_.get();
-  }
-
-  NativeViewHost* host() {
-    return host_.get();
+    return static_cast<NativeViewHostAura*>(GetNativeWrapper());
   }
 
   Widget* child() {
     return child_.get();
   }
 
   aura::Window* clipping_window() { return &(native_host()->clipping_window_); }
 
   void CreateHost() {
-    // Create the top level widget.
-    toplevel_.reset(new Widget);
-    Widget::InitParams toplevel_params =
-        CreateParams(Widget::InitParams::TYPE_WINDOW);
-    toplevel_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
-    toplevel_->Init(toplevel_params);
-
-    // And the child widget.
-    child_.reset(new Widget);
-    Widget::InitParams child_params(Widget::InitParams::TYPE_CONTROL);
-    child_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
-    child_params.parent = toplevel_->GetNativeView();
-    child_->Init(child_params);
-    child_->SetContentsView(new View);
-
-    // Owned by |toplevel|.
-    host_.reset(new NativeViewHostTesting);
-    toplevel_->GetRootView()->AddChildView(host_.get());
-    host_->Attach(child_->GetNativeView());
+    CreateTopLevel();
+    CreateTestingHost();
+    child_.reset(CreateChildForHost(toplevel()->GetNativeView(),
+                                    toplevel()->GetRootView(),
+                                    new View,
+                                    host()));
   }
 
-  void DestroyHost() {
-    host_.reset();
-  }
-
-  NativeViewHostTesting* ReleaseHost() { return host_.release(); }
-
-  void DestroyTopLevel() { toplevel_.reset(); }
-
  private:
-  scoped_ptr<Widget> toplevel_;
-  scoped_ptr<NativeViewHostTesting> host_;
   scoped_ptr<Widget> child_;
 
   DISALLOW_COPY_AND_ASSIGN(NativeViewHostAuraTest);
 };
 
 // Verifies NativeViewHostAura stops observing native view on destruction.
 TEST_F(NativeViewHostAuraTest, StopObservingNativeViewOnDestruct) {
   CreateHost();
   aura::Window* child_win = child()->GetNativeView();
   NativeViewHostAura* aura_host = native_host();
@@ skipping 40 matching lines @@
 
   EXPECT_EQ(ui::kCursorWait, host()->GetCursor(move_event).native_type());
 
   DestroyHost();
 }
 
 // Test that destroying the top level widget before destroying the attached
 // NativeViewHost works correctly. Specifically the associated NVH should be
 // destroyed and there shouldn't be any errors.
 TEST_F(NativeViewHostAuraTest, DestroyWidget) {
-  NativeViewHostTesting::ResetDestroyedCount();
+  ResetHostDestroyedCount();
   CreateHost();
   ReleaseHost();
-  EXPECT_EQ(0, NativeViewHostTesting::destroyed_count());
+  EXPECT_EQ(0, host_destroyed_count());
   DestroyTopLevel();
-  EXPECT_EQ(1, NativeViewHostTesting::destroyed_count());
+  EXPECT_EQ(1, host_destroyed_count());
 }
 
 // Test that the fast resize path places the clipping and content windows were
 // they are supposed to be.
 TEST_F(NativeViewHostAuraTest, FastResizePath) {
   CreateHost();
   toplevel()->SetBounds(gfx::Rect(20, 20, 100, 100));
 
   // Without fast resize, the clipping window should size to the native view
   // with the native view positioned at the origin of the clipping window and
@@ skipping 162 matching lines @@
 
   host()->SetVisible(false);
   EXPECT_FALSE(clipping_window()->IsVisible());
   EXPECT_FALSE(child()->IsVisible());
 
   DestroyHost();
   DestroyTopLevel();
 }
 
 }  // namespace views