Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 530913003: Remove unnecessary codes (associated with save image feature) (Closed)

Created:
6 years, 3 months ago by zino
Modified:
6 years, 3 months ago
CC:
abarth-chromium, blink-reviews, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, jamesr, Nate Chapin, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove unnecessary codes (associated with save image feature) This CL removes the unnecessary codes which is related to the |save image for canvas| feature. We no longer need the codes because we have already introduced the saveImageFromData() method to the following CL. https://crrev.com/518043003 BUG=401888 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182334

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -21 lines) Patch
M Source/core/loader/NavigationPolicy.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/HitTestResult.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 1 1 chunk +2 lines, -13 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download
M public/web/WebNavigationPolicy.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (3 generated)
zino
Please take a look. Thank you.
6 years, 3 months ago (2014-09-02 07:42:54 UTC) #1
zino
Please take a look. Thank you.
6 years, 3 months ago (2014-09-02 07:43:37 UTC) #3
Justin Novosad
On 2014/09/02 07:43:37, zino wrote: > Please take a look. > > Thank you. lgtm
6 years, 3 months ago (2014-09-02 14:14:22 UTC) #4
Ken Russell (switch to Gerrit)
Please see my comments on your other CLs. I think one of these enums should ...
6 years, 3 months ago (2014-09-04 00:24:01 UTC) #5
zino
On 2014/09/04 00:24:01, Ken Russell wrote: > Please see my comments on your other CLs. ...
6 years, 3 months ago (2014-09-16 22:18:47 UTC) #6
Ken Russell (switch to Gerrit)
Sorry for the delay. LGTM this time.
6 years, 3 months ago (2014-09-18 17:51:38 UTC) #7
zino
Ping @jochen, This CL also needs your approval for public/web/* The pieces of codes (includes ...
6 years, 3 months ago (2014-09-19 01:00:41 UTC) #9
zino
Ping @jochen, This CL also needs your approval for public/web/* The pieces of codes (includes ...
6 years, 3 months ago (2014-09-19 01:01:13 UTC) #10
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-19 13:28:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/530913003/20001
6 years, 3 months ago (2014-09-19 14:14:41 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 15:20:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182334

Powered by Google App Engine
This is Rietveld 408576698