Fixed test memory leaks

src/debug.cc

Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index 7e0b298925e222070f56bde5fd6af03403d83e65..3813201d0ebf84c46ca4795de956fb0d067b6d0a 100644
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -1737,6 +1737,12 @@ void Debugger::SetEventListener(Handle<Object> callback,
 }
 
 
+void Debugger::TearDown() {
+  if (message_thread_ != NULL)
+    message_thread_->Stop();

[Søren Thygesen Gjesse, 2009/03/26 10:50:09]

Please add { }'s

Why don't you have to delete message_thread_ here to avoid leaking?

[Christian Plesner Hansen, 2009/03/27 00:24:26]

Done.

Technically it's not a leak as long as there's a static variable pointing to it.
 But yes, it might as well be deleted.

+}
+
+
 void Debugger::SetMessageHandler(v8::DebugMessageHandler handler, void* data) {
   message_handler_ = handler;
   message_handler_data_ = data;
@@ -1852,16 +1858,23 @@ void Debugger::StopAgent() {
 DebugMessageThread::DebugMessageThread()
     : host_running_(true),
       command_queue_(kQueueInitialSize),
-      message_queue_(kQueueInitialSize) {
+      message_queue_(kQueueInitialSize),
+      keep_running_(true) {
   command_received_ = OS::CreateSemaphore(0);
   message_received_ = OS::CreateSemaphore(0);
 }
 
-// Does not free resources held by DebugMessageThread
-// because this cannot be done thread-safely.
+// Should only be done after the thread is done running.
 DebugMessageThread::~DebugMessageThread() {
+  delete command_received_;
+  delete message_received_;
 }
 
+void DebugMessageThread::Stop() {
+  keep_running_ = false;
+  SendMessage(Vector<uint16_t>(NULL, 0));
+  Join();
+}
 
 // Puts an event coming from V8 on the queue.  Creates
 // a copy of the JSON formatted event string managed by the V8.
@@ -1909,7 +1922,7 @@ bool DebugMessageThread::SetEventJSONFromEvent(Handle<Object> event_data) {
 
 void DebugMessageThread::Run() {
   // Sends debug events to an installed debugger message callback.
-  while (true) {
+  while (keep_running_) {
     // Wait and Get are paired so that semaphore count equals queue length.
     message_received_->Wait();
     Logger::DebugTag("Get message from event message_queue.");