Fixed test memory leaks

test/message/testcfg.py

 # Copyright 2008 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 22 matching lines @@
 FLAGS_PATTERN = re.compile(r"//\s+Flags:(.*)")
 
 class MessageTestCase(test.TestCase):
 
   def __init__(self, path, file, expected, mode, context, config):
     super(MessageTestCase, self).__init__(context, path)
     self.file = file
     self.expected = expected
     self.config = config
     self.mode = mode
 

[Søren Thygesen Gjesse, 2009/03/26 10:50:09]

Please add a comment on why these lines are ignored.

[Christian Plesner Hansen, 2009/03/27 00:24:26]

Done

+  def IgnoreLine(self, str):
+    if not str: return True
+    else: return str.startswith('==') or str.startswith('**')
+
   def IsFailureOutput(self, output):
     f = file(self.expected)
     # Skip initial '#' comment and spaces
     for line in f:
       if (not line.startswith('#')) and (not line.strip()):
         break
     # Convert output lines to regexps that we can match
     env = { 'basename': basename(self.file) }
     patterns = [ ]
     for line in f:
       if not line.strip():
         continue
       pattern = re.escape(line.rstrip() % env)
       pattern = pattern.replace('\\*', '.*')
       pattern = '^%s$' % pattern
       patterns.append(pattern)
     # Compare actual output with the expected
-    outlines = [ s for s in output.stdout.split('\n') if s ]
+    raw_lines = output.stdout.split('\n')
+    outlines = [ s for s in raw_lines if not self.IgnoreLine(s) ]
     if len(outlines) != len(patterns):
       return True
     for i in xrange(len(patterns)):
       if not re.match(patterns[i], outlines[i]):
         return True
     return False
 
   def GetLabel(self):
     return "%s %s" % (self.mode, self.GetName())
 
@@ skipping 48 matching lines @@
     return ['sample', 'sample=shell']
 
   def GetTestStatus(self, sections, defs):
     status_file = join(self.root, 'message.status')
     if exists(status_file):
       test.ReadConfigurationInto(status_file, sections, defs)
 
 
 def GetConfiguration(context, root):
   return MessageTestConfiguration(context, root)