Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 530793002: Add Collections perf tests to v8 public repo. (Closed)

Created:
6 years, 3 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 3 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev, arv (Not doing code reviews), adamk
Project:
v8
Visibility:
Public.

Description

Add Collections perf tests to v8 public repo. R=machenbach@chromium.org BUG=374708 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=23570

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+474 lines, -55 lines) Patch
A test/perf-test/Collections/Collections.json View 1 chunk +15 lines, -0 lines 0 comments Download
A + test/perf-test/Collections/base.js View 1 8 chunks +138 lines, -55 lines 0 comments Download
A test/perf-test/Collections/map.js View 1 1 chunk +81 lines, -0 lines 0 comments Download
A test/perf-test/Collections/run.js View 1 1 chunk +30 lines, -0 lines 0 comments Download
A test/perf-test/Collections/set.js View 1 1 chunk +66 lines, -0 lines 0 comments Download
A test/perf-test/Collections/weakmap.js View 1 1 chunk +80 lines, -0 lines 0 comments Download
A test/perf-test/Collections/weakset.js View 1 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dmitry Lomov (no reviews)
PTAL
6 years, 3 months ago (2014-09-01 14:30:00 UTC) #1
Michael Achenbach
LGTM https://codereview.chromium.org/530793002/diff/1/test/perf-test/Collections/base.js File test/perf-test/Collections/base.js (right): https://codereview.chromium.org/530793002/diff/1/test/perf-test/Collections/base.js#newcode1 test/perf-test/Collections/base.js:1: // Copyright 2013 the V8 project authors. All ...
6 years, 3 months ago (2014-09-01 14:39:43 UTC) #2
Michael Achenbach
LGTM
6 years, 3 months ago (2014-09-01 14:51:46 UTC) #3
Dmitry Lomov (no reviews)
6 years, 3 months ago (2014-09-01 14:52:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 23570 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698