Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 530703003: MediaGalleriesGalleryWatchApiTest: Enable tests that were disabled. (Closed)

Created:
6 years, 3 months ago by Oren Blasberg
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, extensions-reviews_chromium.org, vandebo (ex-Chrome), Lei Zhang, tommycli, Greg Billock, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

MediaGalleriesGalleryWatchApiTest: Enable tests that were disabled. They should no longer be flaky/crashing because the underlying watch manager is new, shiny, and more stable. BUG=390979 Committed: https://crrev.com/51dad2069bee06c255bdb00d1f7e2be905e0a7db Cr-Commit-Position: refs/heads/master@{#292995}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Formatting nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc View 1 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Oren Blasberg
6 years, 3 months ago (2014-09-02 17:24:27 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/530703003/diff/1/chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc File chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc (right): https://codereview.chromium.org/530703003/diff/1/chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc#newcode196 chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc:196: BasicGalleryWatch) { fits on prev line
6 years, 3 months ago (2014-09-02 18:56:53 UTC) #3
Oren Blasberg
https://codereview.chromium.org/530703003/diff/1/chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc File chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc (right): https://codereview.chromium.org/530703003/diff/1/chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc#newcode196 chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc:196: BasicGalleryWatch) { On 2014/09/02 18:56:53, Lei Zhang wrote: > ...
6 years, 3 months ago (2014-09-02 19:04:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/orenb@chromium.org/530703003/20001
6 years, 3 months ago (2014-09-02 19:05:06 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 3 months ago (2014-09-02 20:01:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 8edb653e155be5a28bfa0b71f57e78a9c7d65aad
6 years, 3 months ago (2014-09-02 20:52:54 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:20:42 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/51dad2069bee06c255bdb00d1f7e2be905e0a7db
Cr-Commit-Position: refs/heads/master@{#292995}

Powered by Google App Engine
This is Rietveld 408576698