Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 530693002: [turbofan] Merge compiler unit tests into src. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
titzer, Sven Panne
CC:
v8-dev, danno
Project:
v8
Visibility:
Public.

Description

[turbofan] Merge compiler unit tests into src. BUG=v8:3489 LOG=n R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23551

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -6106 lines) Patch
M build/all.gyp View 1 chunk +1 line, -1 line 0 comments Download
A src/compiler/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A + src/compiler/arm/instruction-selector-arm-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/compiler/change-lowering-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/compiler/common-operator-unittest.cc View 1 chunk +15 lines, -5 lines 0 comments Download
A + src/compiler/compiler.gyp View 1 chunk +2 lines, -1 line 0 comments Download
A + src/compiler/compiler-unittests.h View 1 chunk +5 lines, -0 lines 0 comments Download
A + src/compiler/compiler-unittests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + src/compiler/graph-unittest.h View 4 chunks +8 lines, -5 lines 0 comments Download
A + src/compiler/graph-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + src/compiler/ia32/instruction-selector-ia32-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/compiler/instruction-selector-unittest.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + src/compiler/instruction-selector-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/compiler/machine-operator-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/compiler/machine-operator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/compiler/x64/instruction-selector-x64-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D test/compiler-unittests/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D test/compiler-unittests/arm/instruction-selector-arm-unittest.cc View 1 chunk +0 lines, -1900 lines 0 comments Download
D test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +0 lines, -494 lines 0 comments Download
D test/compiler-unittests/change-lowering-unittest.cc View 1 chunk +0 lines, -478 lines 0 comments Download
D test/compiler-unittests/common-operator-unittest.h View 1 chunk +0 lines, -31 lines 0 comments Download
D test/compiler-unittests/common-operator-unittest.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D test/compiler-unittests/compiler-unittests.h View 1 chunk +0 lines, -85 lines 0 comments Download
D test/compiler-unittests/compiler-unittests.cc View 1 chunk +0 lines, -90 lines 0 comments Download
D test/compiler-unittests/compiler-unittests.gyp View 1 chunk +0 lines, -81 lines 0 comments Download
D test/compiler-unittests/graph-unittest.h View 1 chunk +0 lines, -128 lines 0 comments Download
D test/compiler-unittests/graph-unittest.cc View 1 chunk +0 lines, -758 lines 0 comments Download
D test/compiler-unittests/ia32/instruction-selector-ia32-unittest.cc View 1 chunk +0 lines, -211 lines 0 comments Download
D test/compiler-unittests/instruction-selector-unittest.h View 1 chunk +0 lines, -202 lines 0 comments Download
D test/compiler-unittests/instruction-selector-unittest.cc View 1 chunk +0 lines, -431 lines 0 comments Download
D test/compiler-unittests/machine-operator-reducer-unittest.cc View 1 chunk +0 lines, -443 lines 0 comments Download
D test/compiler-unittests/machine-operator-unittest.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D test/compiler-unittests/simplified-operator-reducer-unittest.cc View 1 chunk +0 lines, -481 lines 0 comments Download
D test/compiler-unittests/x64/instruction-selector-x64-unittest.cc View 1 chunk +0 lines, -111 lines 0 comments Download
M tools/presubmit.py View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
6 years, 3 months ago (2014-09-01 09:49:48 UTC) #1
Sven Panne
LGTM (mostly rubberstamped)
6 years, 3 months ago (2014-09-01 10:16:05 UTC) #2
Benedikt Meurer
Committed patchset #1 (id:1) manually as 23551 (presubmit successful).
6 years, 3 months ago (2014-09-01 10:26:56 UTC) #3
titzer
On 2014/09/01 10:26:56, Benedikt Meurer wrote: > Committed patchset #1 (id:1) manually as 23551 (presubmit ...
6 years, 3 months ago (2014-09-02 15:12:55 UTC) #4
Benedikt Meurer
6 years, 3 months ago (2014-09-03 04:33:56 UTC) #6
Message was sent while issue was closed.
On 2014/09/02 at 15:12:55, titzer wrote:
> On 2014/09/01 10:26:56, Benedikt Meurer wrote:
> > Committed patchset #1 (id:1) manually as 23551 (presubmit successful).
> 
> NOT LGTM
> 
> This was *not* agreed upon and I very strongly disagree putting these test
here. Please move it back.

Argh, both me and Jochen asked a few weeks ago, and at least from what I got,
Michi was the last one complaining. And besides that the whole team decided
several times that we will follow the Google/Chromium Coding Style, and the
Chromium Coding Style (http://www.chromium.org/developers/coding-style) is
pretty clear about it: "Unit tests and performance tests should be placed in the
same directory as the functionality they're testing." (in section "Naming"). So,
either we *DO FOLLOW* the coding style or we *DON'T FOLLOW* it; feel free to
bring up the discussion with our tech lead again, but no half-baked "let's pick
rule 1, 3 and 5, but not 2 and 4", that doesn't scale and just lead to these
stupid discussions every now and then!

Powered by Google App Engine
This is Rietveld 408576698