Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 530623002: Use qualified path for three more grit headers from ui. (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use qualified path for three more grit headers from ui. They are: - app_locale_settings.h - ui_unscaled_resources.h - webui_resources.h BUG=401588 TEST=None R=thestig@chromium.org,thakis@chromium.org TBR=darin@chromium.org Committed: https://crrev.com/272c8d7b1978f66b18b9621bf1ec4c9692f18e9f Cr-Commit-Position: refs/heads/master@{#293655}

Patch Set 1 #

Patch Set 2 : GYP + GN changes #

Patch Set 3 : REBASE #

Patch Set 4 : fixes for webui_resources_map? #

Patch Set 5 : fix GN too? #

Patch Set 6 : ui_resources too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/data/webui/webui_resource_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/DEPS View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/webui/shared_resources_data_source.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/common/cursors/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/browser_test_utils.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/test/webui_resource_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/DEPS View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/cursor/cursor_loader_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ui/base/webui/jstemplate_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/webui/web_ui_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/resources/BUILD.gn View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M ui/strings/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ui/strings/ui_strings.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 24 (10 generated)
tfarina
6 years, 3 months ago (2014-09-01 16:25:34 UTC) #1
Nico
The code change lgtm, but ui/strings/ui_strings.gyp no longer should need grit_target.gypi now. ui/resources/ui_resources.gyp either. And ...
6 years, 3 months ago (2014-09-01 19:14:17 UTC) #2
tfarina
TBRing Darin for this... On 2014/09/01 19:14:17, Nico (hiding) wrote: > The code change lgtm, ...
6 years, 3 months ago (2014-09-07 00:58:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/530623002/20001
6 years, 3 months ago (2014-09-07 01:01:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2699) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/6109) ios_rel_device ...
6 years, 3 months ago (2014-09-07 01:05:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/530623002/40001
6 years, 3 months ago (2014-09-07 01:11:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2700) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/6110) linux_chromium_gn_rel ...
6 years, 3 months ago (2014-09-07 01:18:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/530623002/60001
6 years, 3 months ago (2014-09-07 01:27:42 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/13048)
6 years, 3 months ago (2014-09-07 01:34:59 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/530623002/90001
6 years, 3 months ago (2014-09-07 01:43:51 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/6124)
6 years, 3 months ago (2014-09-07 03:31:53 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/530623002/90001
6 years, 3 months ago (2014-09-07 04:53:20 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:90001) as aeb2606d33f94950d2324667452807351e49b52a
6 years, 3 months ago (2014-09-07 05:50:23 UTC) #23
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:44:03 UTC) #24
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/272c8d7b1978f66b18b9621bf1ec4c9692f18e9f
Cr-Commit-Position: refs/heads/master@{#293655}

Powered by Google App Engine
This is Rietveld 408576698