Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2044)

Unified Diff: Tools/GardeningServer/ui/ct-unexpected-failures.html

Issue 530613002: Fix partytime. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/ui/ct-party-time.html ('k') | Tools/GardeningServer/ui/test/ct-party-time-tests.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/ct-unexpected-failures.html
diff --git a/Tools/GardeningServer/ui/ct-unexpected-failures.html b/Tools/GardeningServer/ui/ct-unexpected-failures.html
index 0f06bc0e5ae334f220727fa4b0bb416ddc01fffb..38dc064e80560cbb1689386af53bd0166bd79776 100644
--- a/Tools/GardeningServer/ui/ct-unexpected-failures.html
+++ b/Tools/GardeningServer/ui/ct-unexpected-failures.html
@@ -45,10 +45,12 @@ found in the LICENSE file.
</div>
<ct-tree-status status="{{ treeStatuses['chromium'] }}" state="{{ treeStatuses['chromium'].status }}"></ct-tree-status>
<ct-tree-status status="{{ treeStatuses['blink'] }}" state="{{ treeStatuses['blink'].status }}"></ct-tree-status>
- <ct-party-time failures="{{ failures.failures[tree].length == 0 }}"></ct-party-time>
- <ct-failure-stream title="Reliable failures" category="default" groups="{{ failures.failures[tree] }}" commitLog="{{ commitLog }}" tree="{{ tree }}"></ct-failure-stream>
- <ct-failure-stream title="Failures that have only happened once (on one bot)" category="failedOnce" groups="{{ failures.failures[tree] }}" commitLog="{{ commitLog }}" tree="{{ tree }}"></ct-failure-stream>
- <ct-failure-stream title="Snoozed failures" category="snoozed" groups="{{ failures.failures[tree] }}" commitLog="{{ commitLog }}" tree="{{ tree }}"></ct-failure-stream>
+ <template if="{{ failures && failures.failures && (!failures.failures[tree] || !failures.failures[tree].length) }}">
+ <ct-party-time></ct-party-time>
+ </template>
+ <ct-failure-stream title="Reliable failures" category="default" groups="{{ failures && failures.failures[tree] }}" commitLog="{{ commitLog }}" tree="{{ tree }}"></ct-failure-stream>
+ <ct-failure-stream title="Failures that have only happened once (on one bot)" category="failedOnce" groups="{{ failures && failures.failures[tree] }}" commitLog="{{ commitLog }}" tree="{{ tree }}"></ct-failure-stream>
+ <ct-failure-stream title="Snoozed failures" category="snoozed" groups="{{ failures && failures.failures[tree] }}" commitLog="{{ commitLog }}" tree="{{ tree }}"></ct-failure-stream>
</template>
<script>
(function() {
« no previous file with comments | « Tools/GardeningServer/ui/ct-party-time.html ('k') | Tools/GardeningServer/ui/test/ct-party-time-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698