Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2448)

Unified Diff: Tools/GardeningServer/ui/ct-unexpected-failures.html

Issue 530613002: Fix partytime. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-unexpected-failures.html
diff --git a/Tools/GardeningServer/ui/ct-unexpected-failures.html b/Tools/GardeningServer/ui/ct-unexpected-failures.html
index 4bb6946c82a6218acb357356cd2adbcfcc71e3a5..141dafb44d9adf02410d29fdf5acd669792f6e92 100644
--- a/Tools/GardeningServer/ui/ct-unexpected-failures.html
+++ b/Tools/GardeningServer/ui/ct-unexpected-failures.html
@@ -41,9 +41,9 @@ found in the LICENSE file.
</div>
<ct-tree-status status="{{ treeStatuses['chromium'] }}" state="{{ treeStatuses['chromium'].status }}"></ct-tree-status>
<ct-tree-status status="{{ treeStatuses['blink'] }}" state="{{ treeStatuses['blink'].status }}"></ct-tree-status>
- <ct-party-time failures="{{ failures.failures[tree].length == 0 }}"></ct-party-time>
- <ct-failure-stream category="default" groups="{{ failures.failures[tree] }}" commitLog="{{ commitLog }}" tree="{{ tree }}"></ct-failure-stream>
- <ct-failure-stream category="snoozed" groups="{{ failures.failures[tree] }}" commitLog="{{ commitLog }}" tree="{{ tree }}"></ct-failure-stream>
+ <ct-party-time partytime="{{ !failures || !failures.failures[tree] || failures.failures[tree].length == 0 }}"></ct-party-time>
Jeffrey Yasskin 2014/09/02 18:34:52 I keep assuming that Polymer's templates parse the
michaelpg 2014/09/02 21:57:33 I feel like this would be better as a conditional
ojan 2014/09/11 03:04:47 Yeah, that's much better. Done.
+ <ct-failure-stream category="default" groups="{{ failures && failures.failures[tree] }}" commitLog="{{ commitLog }}" tree="{{ tree }}"></ct-failure-stream>
+ <ct-failure-stream category="snoozed" groups="{{ failures && failures.failures[tree] }}" commitLog="{{ commitLog }}" tree="{{ tree }}"></ct-failure-stream>
ojan 2014/09/01 00:31:15 These changes are to make createElement(ct-unexpec
</template>
<script>
(function() {

Powered by Google App Engine
This is Rietveld 408576698