Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: tools/buildbot/perf/dashboard/ui/generic_plotter.html

Issue 53061: Fix details.html to handle new data file names and formats. Remove old, unuse... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/buildbot/perf/dashboard/ui/details.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <html> 1 <html>
2 2
3 <!-- 3 <!--
4 Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 4 Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
5 Use of this source code is governed by a BSD-style license that can be 5 Use of this source code is governed by a BSD-style license that can be
6 found in the LICENSE file. 6 found in the LICENSE file.
7 --> 7 -->
8 8
9 <!-- 9 <!--
10 A brief note on terminology as used here: a "graph" is a plotted screenful 10 A brief note on terminology as used here: a "graph" is a plotted screenful
11 of data, showing the results of one type of test: for example, the 11 of data, showing the results of one type of test: for example, the
12 page-load-time graph. A "trace" is a single line on a graph, showing one 12 page-load-time graph. A "trace" is a single line on a graph, showing one
13 one for the test: for example, the reference build trace on the 13 one for the test: for example, the reference build trace on the
14 page-load-time graph. 14 page-load-time graph.
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 <script src="js/common.js"></script> 91 <script src="js/common.js"></script>
92 <script src="js/plotter.js"></script> 92 <script src="js/plotter.js"></script>
93 <script src="js/coordinates.js"></script> 93 <script src="js/coordinates.js"></script>
94 <script src="config.js"></script> 94 <script src="config.js"></script>
95 <script> 95 <script>
96 document.title = Config.title; 96 document.title = Config.title;
97 97
98 var did_position_details = false; 98 var did_position_details = false;
99 var units = 'thing-a-ma-bobs'; 99 var units = 'thing-a-ma-bobs';
100 var graph_list = []; 100 var graph_list = [];
101 var first_trace = '';
101 102
102 var params = ParseParams(); 103 var params = ParseParams();
103 if (!('history' in params)) { 104 if (!('history' in params)) {
104 params.history = 150; 105 params.history = 150;
105 // make this option somewhat user discoverable :-/ 106 // make this option somewhat user discoverable :-/
106 window.location.href = MakeURL(params); 107 window.location.href = MakeURL(params);
107 } 108 }
108 109
109 function jsonToJs(data) { 110 function jsonToJs(data) {
110 return eval('(' + data + ')') 111 return eval('(' + data + ')')
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 function on_clicked_plot(prev_cl, cl) { 152 function on_clicked_plot(prev_cl, cl) {
152 if ('lookout' in params) { 153 if ('lookout' in params) {
153 window.open(get_url()); 154 window.open(get_url());
154 return; 155 return;
155 } 156 }
156 157
157 document.getElementById('view-change'). 158 document.getElementById('view-change').
158 setAttribute('src', Config.changeLinkPrefix + prev_cl + ':' + cl); 159 setAttribute('src', Config.changeLinkPrefix + prev_cl + ':' + cl);
159 160
160 document.getElementById('view-pages'). 161 document.getElementById('view-pages').
161 setAttribute('src', 'details.html?cl=' + cl); 162 setAttribute('src', 'details.html?cl=' + cl + '&trace=' + first_trace);
162 163
163 if (!did_position_details) { 164 if (!did_position_details) {
164 position_details(); 165 position_details();
165 did_position_details = true; 166 did_position_details = true;
166 } 167 }
167 } 168 }
168 169
169 function received_summary(data) { 170 function received_summary(data) {
170 // Parse the summary data file. 171 // Parse the summary data file.
171 var rows = data.split('\n'); 172 var rows = data.split('\n');
(...skipping 19 matching lines...) Expand all
191 } 192 }
192 193
193 // Build a list of all the trace names we've seen, in the order in which 194 // Build a list of all the trace names we've seen, in the order in which
194 // they appear in the data file. Although JS objects are not required by 195 // they appear in the data file. Although JS objects are not required by
195 // the spec to iterate their properties in order, in practice they do, 196 // the spec to iterate their properties in order, in practice they do,
196 // because it causes compatibility problems otherwise. 197 // because it causes compatibility problems otherwise.
197 var traceNames = []; 198 var traceNames = [];
198 for (var traceName in allTraces) 199 for (var traceName in allTraces)
199 traceNames.push(traceName); 200 traceNames.push(traceName);
200 201
202 first_trace = traceNames[0];
203
201 // Build and numerically sort a list of revision numbers. 204 // Build and numerically sort a list of revision numbers.
202 var revisionNumbers = []; 205 var revisionNumbers = [];
203 for (var rev in graphData) 206 for (var rev in graphData)
204 revisionNumbers.push(rev); 207 revisionNumbers.push(rev);
205 revisionNumbers.sort( 208 revisionNumbers.sort(
206 function(a, b) { return parseInt(a, 10) - parseInt(b, 10) }); 209 function(a, b) { return parseInt(a, 10) - parseInt(b, 10) });
207 210
208 // Build separate ordered lists of trace data. 211 // Build separate ordered lists of trace data.
209 var traceData = {}; 212 var traceData = {};
210 for (var revIndex = 0; revIndex < revisionNumbers.length; ++revIndex) { 213 for (var revIndex = 0; revIndex < revisionNumbers.length; ++revIndex) {
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 details.style.display = "none"; 355 details.style.display = "none";
353 header_text.style.display = "none"; 356 header_text.style.display = "none";
354 explain.style.display = "none"; 357 explain.style.display = "none";
355 selection.style.display = "none"; 358 selection.style.display = "none";
356 } else { 359 } else {
357 document.getElementById("header_lookout").style.display = "none"; 360 document.getElementById("header_lookout").style.display = "none";
358 } 361 }
359 </script> 362 </script>
360 </body> 363 </body>
361 </html> 364 </html>
OLDNEW
« no previous file with comments | « tools/buildbot/perf/dashboard/ui/details.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698