Source/web/PageScaleConstraintsSet.h - Issue 53053002: [Android WebView] Add a legacy quirk for 'user-scalable=no' case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PageScaleConstraintsSet.h

Issue 53053002: [Android WebView] Add a legacy quirk for 'user-scalable=no' case (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rewritten according to aelias@' proposal Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/PageScaleConstraintsSet.h

diff --git a/Source/web/PageScaleConstraintsSet.h b/Source/web/PageScaleConstraintsSet.h

index c2c67424a92436afc1be39ac3b99958d581c5fc0..dc90dcf74054b9a163a203efc9996c8b1b4d1464 100644

--- a/Source/web/PageScaleConstraintsSet.h

+++ b/Source/web/PageScaleConstraintsSet.h

@@ -49,7 +49,7 @@ public:

// is enabled.

const WebCore::PageScaleConstraints& pageDefinedConstraints() const { return m_pageDefinedConstraints; }

void updatePageDefinedConstraints(const WebCore::ViewportDescription&, WebCore::IntSize viewSize);

- void adjustForAndroidWebViewQuirks(const WebCore::ViewportDescription&, WebCore::IntSize viewSize, int layoutFallbackWidth, float deviceScaleFactor, bool supportTargetDensityDPI, bool wideViewportQuirkEnabled, bool useWideViewport, bool loadWithOverviewMode);

+ void adjustForAndroidWebViewQuirks(const WebCore::ViewportDescription&, WebCore::IntSize viewSize, int layoutFallbackWidth, float deviceScaleFactor, bool supportTargetDensityDPI, bool wideViewportQuirkEnabled, bool useWideViewport, bool loadWithOverviewMode, bool nonUserScalableQuirkEnabled);

eseidel 2013/11/05 20:09:54 This is almost ready to use a struct to hold its a

// Constraints may also be set from Chromium -- this overrides any

// page-defined values.

« no previous file with comments | « no previous file | Source/web/PageScaleConstraintsSet.cpp » ('j') | Source/web/PageScaleConstraintsSet.cpp » ('J')