Issue 53047: Implement string.match in C++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 53047: Implement string.match in C++. (Closed)

Created:
11 years, 9 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Moved String.prototype.match implementation to C++. Some extra runtime assertions added.

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -232 lines)			Patch
M	src/jsregexp.h	View	2 chunks	+3 lines, -19 lines	0 comments	Download
M	src/jsregexp.cc	View	6 chunks	+12 lines, -173 lines	0 comments	Download
M	src/platform-win32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/regexp-macro-assembler-ia32.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/runtime.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View	3 chunks	+54 lines, -18 lines	0 comments	Download
M	src/string.js	View	1 chunk	+2 lines, -15 lines	1 comment	Download
M	test/mjsunit/regexp-indexof.js	View	2 chunks	+22 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

11 years, 9 months ago (2009-03-25 11:29:46 UTC) #2

STV!

http://codereview.chromium.org/53047/diff/1/8
File src/string.js (right):

http://codereview.chromium.org/53047/diff/1/8#newcode160
Line 160: // lastMatchInfo is defined in regexp-delay.js
full stop

Expand Messages | Collapse Messages