Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: pdf/instance.h

Issue 530363002: Prevent the in-process PDF plugin re-entering into JS during blink layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pdf/instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/instance.h
diff --git a/pdf/instance.h b/pdf/instance.h
index c377b032c0f69c5490bbb58e89a1e5af72b44f20..2218c0d17675ac4d7ff75c9582353d6295e2f424 100644
--- a/pdf/instance.h
+++ b/pdf/instance.h
@@ -202,6 +202,9 @@ class Instance : public pp::InstancePrivate,
// scrollbars, background parts, and notifies the pdf engine.
void OnGeometryChanged(double old_zoom, float old_device_scale);
+ // Runs the given JS callback given in |callback|.
+ void RunCallback(int32_t, pp::Var callback);
+
void CreateHorizontalScrollbar();
void CreateVerticalScrollbar();
void DestroyHorizontalScrollbar();
@@ -456,8 +459,10 @@ class Instance : public pp::InstancePrivate,
pp::CompletionCallbackFactory<Instance> form_factory_;
pp::URLLoader form_loader_;
- // Used for printing without re-entrancy issues.
- pp::CompletionCallbackFactory<Instance> print_callback_factory_;
+ // Used for generating callbacks.
+ // TODO(raymes): We don't really need other callback factories we can just
+ // fold them into this one.
+ pp::CompletionCallbackFactory<Instance> callback_factory_;
// True if we haven't painted the plugin viewport yet.
bool first_paint_;
« no previous file with comments | « no previous file | pdf/instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698