Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 530363002: Prevent the in-process PDF plugin re-entering into JS during blink layout (Closed)

Created:
6 years, 3 months ago by raymes
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Prevent the in-process PDF plugin re-entering into JS during blink layout Layout changes trigger view changes which get sent to the plugin. With the in process plugin (PDF), the plugin is notified synchronously of the view change. It then might execute scripts synchronously in the plugin but scripts are not meant to be executed during layout changes. This change runs the scripts asynchronously. I tested print preview to ensure that it still works correctly. Note that once we remove in-process plugins this won't be an issue because view changes happen asynchronously out of process (besides the fact that synchronous script execution is limited to private plugins). BUG=351636 Committed: https://crrev.com/8410df4f4a7c54f2d669b6cc717ec9a09b76ad79 Cr-Commit-Position: refs/heads/master@{#293256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M pdf/instance.h View 2 chunks +7 lines, -2 lines 0 comments Download
M pdf/instance.cc View 4 chunks +19 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
raymes
6 years, 3 months ago (2014-09-03 04:19:06 UTC) #2
Lei Zhang
lgtm
6 years, 3 months ago (2014-09-03 22:22:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/530363002/1
6 years, 3 months ago (2014-09-03 23:24:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1904)
6 years, 3 months ago (2014-09-04 02:23:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/530363002/1
6 years, 3 months ago (2014-09-04 03:37:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 98cadacd91ab272e7a95304bfe3ec31ad3a554fb
6 years, 3 months ago (2014-09-04 04:29:08 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:29:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8410df4f4a7c54f2d669b6cc717ec9a09b76ad79
Cr-Commit-Position: refs/heads/master@{#293256}

Powered by Google App Engine
This is Rietveld 408576698