Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 530343005: Clean up code stubs and ensure distinct major keys. (Closed)

Created:
6 years, 3 months ago by Yang
Modified:
6 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Clean up code stubs and ensure distinct major keys. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23655

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -409 lines) Patch
M src/arm/code-stubs-arm.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 11 chunks +13 lines, -15 lines 0 comments Download
M src/arm64/code-stubs-arm64.h View 5 chunks +6 lines, -5 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 11 chunks +22 lines, -23 lines 0 comments Download
M src/code-stubs.h View 64 chunks +137 lines, -169 lines 0 comments Download
M src/code-stubs.cc View 6 chunks +5 lines, -10 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M src/ic/handler-compiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +0 lines, -46 lines 1 comment Download
M src/ic/ic.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/ic/ic-compiler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 10 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 3 months ago (2014-09-03 12:48:17 UTC) #1
mvstanton
Looks good. LGTM. https://codereview.chromium.org/530343005/diff/1/src/ic/ia32/handler-compiler-ia32.cc File src/ic/ia32/handler-compiler-ia32.cc (left): https://codereview.chromium.org/530343005/diff/1/src/ic/ia32/handler-compiler-ia32.cc#oldcode18 src/ic/ia32/handler-compiler-ia32.cc:18: void ElementHandlerCompiler::GenerateLoadDictionaryElement( Nice catch to be ...
6 years, 3 months ago (2014-09-03 12:54:52 UTC) #2
Yang
6 years, 3 months ago (2014-09-03 13:15:14 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 23655 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698