Reland: Issue 446203002: Initialize the now_function to the HighResNowWrapper in case High Res is s…

Reland: Issue 446203002: Initialize the now_function to the HighResNowWrapper in case High Res is supported

https://codereview.chromium.org/446203002/

The reland avoids using a static initializer for now_function, it initializes the function pointer on the first call instead.

I incorporated maruel@'s suggestions.

jam for
chrome/browser/
content/app/

willchan,maruel for
base/time/

BUG=400627
R=cpu@chromium.org, jam@chromium.org, maruel@chromium.org, thakis@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/a7c8e5e3411d6a3d32f4e1a61f8baa3e438fee52

Committed: https://chromium.googlesource.com/chromium/src/+/90f62d687d7e5049cf1f94cea8c59f6c6282437d

[fmeawad, 2014-09-03 00:05:22]

fmeawad@chromium.org changed reviewers:
+ jam@chromium.org, maruel@chromium.org, willchan@chromium.org

[fmeawad, 2014-09-03 00:05:45]

fmeawad@chromium.org changed reviewers:
+ cpu@chromium.org

[fmeawad, 2014-09-03 00:54:43]

PTAL.

[M-A Ruel, 2014-09-03 01:26:13]

<3

lgtm

https://codereview.chromium.org/530293002/diff/1/base/time/time_win.cc
File base/time/time_win.cc (right):

https://codereview.chromium.org/530293002/diff/1/base/time/time_win.cc#newcod...
base/time/time_win.cc:477: reinterpret_cast<PVOID>(RolloverProtectedNow));
s/PVOID/void*/g

[fmeawad, 2014-09-03 18:56:33]

Thanks maruel@ for the quick review, Owners?

https://codereview.chromium.org/530293002/diff/1/base/time/time_win.cc
File base/time/time_win.cc (right):

https://codereview.chromium.org/530293002/diff/1/base/time/time_win.cc#newcod...
base/time/time_win.cc:477: reinterpret_cast<PVOID>(RolloverProtectedNow));
On 2014/09/03 01:26:12, M-A Ruel wrote:
> s/PVOID/void*/g

Done.

[fmeawad, 2014-09-03 18:56:51]

fmeawad@chromium.org changed reviewers:
+ thakis@chromium.org

[fmeawad, 2014-09-03 18:57:36]

+thakis

[cpu_(ooo_6.6-7.5), 2014-09-03 23:27:56]

otherwise lgtm

https://codereview.chromium.org/530293002/diff/20001/base/time/time_win.cc
File base/time/time_win.cc (right):

https://codereview.chromium.org/530293002/diff/20001/base/time/time_win.cc#ne...
base/time/time_win.cc:477: reinterpret_cast<void*>(RolloverProtectedNow));
do you need the second
  reinterpret_cast<void*>(RolloverProtectedNow)

how about &RolloverProtectedNow

[fmeawad, 2014-09-04 17:59:23]

https://codereview.chromium.org/530293002/diff/20001/base/time/time_win.cc
File base/time/time_win.cc (right):

https://codereview.chromium.org/530293002/diff/20001/base/time/time_win.cc#ne...
base/time/time_win.cc:477: reinterpret_cast<void*>(RolloverProtectedNow));
On 2014/09/03 23:27:56, cpu wrote:
> do you need the second
>   reinterpret_cast<void*>(RolloverProtectedNow)
> 
> how about &RolloverProtectedNow

Done.

[jam, 2014-09-04 22:25:59]

lgtm

[Nico, 2014-09-04 22:28:45]

base rs-lgtm

[fmeawad, 2014-09-05 00:45:25]

Committed patchset #3 (id:40001) manually as a7c8e5e.

[fmeawad, 2014-09-05 18:14:06]

Committed patchset #3 (id:40001) manually as 90f62d6 (presubmit successful).

[commit-bot: I haz the power, 2014-09-10 03:40:44]

Patchset 3 (id:??) landed as
https://crrev.com/90f62d687d7e5049cf1f94cea8c59f6c6282437d
Cr-Commit-Position: refs/heads/master@{#293555}