Issue 53028: GRIT rules improvements on windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 53028: GRIT rules improvements on windows (Closed)

Created:
11 years, 9 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

This fixes a few GRIT issues: - The generated header files had the wrong paths specified in the vcproj files. - Have the .h files generate to a temp file and overwrite the real .h files if they changed from the last run. This prevents recompiling when only a resource is changed. - Change the output file to the .rc file because otherwise the vcproj file would recompile every time because the .h file wasn't changing. Since the .rc file gets written all the time, this isn't a problem. On a side note, you still have to re-link to get the resources in chrome.dll. I imagine if you turn on incremental linking, this would be pretty fast. BUG=7967

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -16 lines)			Patch
M	chrome/app/chrome_resources.vcproj	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/app/chrome_strings.vcproj	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	tools/grit/build/grit_resources.rules	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/grit/grit/format/rc_header.py	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	tools/grit/grit/tool/build.py	View	3 chunks	+22 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

awesome, LGTM

Expand Messages | Collapse Messages