Issue 53020: Redone http://codereview.chromium.org/42571

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 53020: Redone http://codereview.chromium.org/42571 (Closed)

Created:
11 years, 9 months ago by Itai

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Redone http://codereview.chromium.org/42571 Issue 6477: Support modifier clicks on UI elements Mouse event flags transformed to WindoOpenDisposition so that browser commands can all inteterpert event modifiers. Implemented home, forward and backwards middle-click andshift middle click. Previously working on issue 358 which was market a duplicate and concerned with the home and tabstrip subset of this behavior: Can't open a new tab by middle-clicking home button. No functionality has been lost or altered, only the use ofmodifiers give access to increased functionality. BUG=6477 TBR=maruel Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12403

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+110 lines, -43 lines)			Patch
M	chrome/browser/automation/automation_provider.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser.h	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/browser.cc	View	7 chunks	+46 lines, -20 lines	0 comments	Download
M	chrome/browser/cocoa/tab_contents_controller.mm	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/location_bar_view_gtk.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/gtk/location_bar_view_gtk.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	chrome/browser/location_bar.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/views/go_button.h	View	4 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/views/go_button.cc	View	3 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/views/toolbar_view.cc	View	6 chunks	+11 lines, -2 lines	0 comments	Download
M	chrome/test/test_location_bar.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/views/controls/button/custom_button.h	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/views/controls/button/custom_button.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download