Fix the form autofill showing when pressing the up arrow key

webkit/glue/editor_client_impl.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The Mac interface forwards most of these commands to the application layer,
 // and I'm not really sure what to do about most of them.
 
 #include "config.h"
 #include "webkit/glue/editor_client_impl.h"
 
@@ skipping 616 matching lines @@
 }
 
 //
 // End of code block subject to Apple, Inc. copyright
 //
 
 void EditorClientImpl::handleKeyboardEvent(WebCore::KeyboardEvent* evt) {
   if (evt->keyCode() == WebCore::VKEY_DOWN ||
       evt->keyCode() == WebCore::VKEY_UP) {
     DCHECK(evt->target()->toNode());
-    ShowAutofillForNode(evt->target()->toNode());
+    if (ShowAutofillForNode(evt->target()->toNode())) {
+      // We will show an autofill popup.  Let's return so we don't handle the
+      // event.  The handling could change the caret position, preventing the
+      // popup from showing (since the actual showing is delayed, see
+      // DoAutofill).
+      return;
+    }
   }
 
   if (handleEditingKeyboardEvent(evt))
     evt->setDefaultHandled();
 }
 
 void EditorClientImpl::handleInputMethodKeydown(WebCore::KeyboardEvent* keyEvent) {
   // We handle IME within chrome.
 }
 
 void EditorClientImpl::textFieldDidBeginEditing(WebCore::Element*) {
 }
 
 void EditorClientImpl::textFieldDidEndEditing(WebCore::Element*) {
   // Notification that focus was lost.  Be careful with this, it's also sent
   // when the page is being closed.
 
   // Cancel any pending DoAutofill calls.
   autofill_factory_.RevokeAll();
 
   // Hide any showing popup.
   web_view_->HideAutoCompletePopup();
 }
 
 void EditorClientImpl::textDidChangeInTextField(WebCore::Element* element) {
   DCHECK(element->hasLocalName(WebCore::HTMLNames::inputTag));
   Autofill(static_cast<WebCore::HTMLInputElement*>(element), false);
 }
 
-void EditorClientImpl::ShowAutofillForNode(WebCore::Node* node) {
+bool EditorClientImpl::ShowAutofillForNode(WebCore::Node* node) {
   WebCore::HTMLInputElement* input_element =
       webkit_glue::NodeToHTMLInputElement(node);
   if (input_element)
-    Autofill(input_element, true);
+    return Autofill(input_element, true);
+  return false;
 }
 
-void EditorClientImpl::Autofill(WebCore::HTMLInputElement* input_element,
+bool EditorClientImpl::Autofill(WebCore::HTMLInputElement* input_element,
                                 bool autofill_on_empty_value) {
   // Cancel any pending DoAutofill calls.
   autofill_factory_.RevokeAll();
 
   // Let's try to trigger autofill for that field, if applicable.
   if (!input_element->isEnabled() || !input_element->isTextField() ||
       input_element->isPasswordField() || !input_element->autoComplete()) {
-    return;
+    return false;
   }
 
   std::wstring name = AutofillForm::GetNameForInputElement(input_element);
   if (name.empty())  // If the field has no name, then we won't have values.
-    return;
+    return false;
 
   // Don't attempt to autofill with values that are too large.
   if (input_element->value().length() > kMaximumTextSizeForAutofill)
-    return;
+    return false;
 
   // We post a task for doing the autofill as the caret position is not set
   // properly at this point ( http://bugs.webkit.org/show_bug.cgi?id=16976)
   // and we need it to determine whether or not to trigger autofill.
   std::wstring value = webkit_glue::StringToStdWString(input_element->value());
   MessageLoop::current()->PostTask(
       FROM_HERE,
       autofill_factory_.NewRunnableMethod(&EditorClientImpl::DoAutofill,
                                           input_element,
                                           autofill_on_empty_value,
                                           backspace_pressed_));
+  return true;
 }
 
 void EditorClientImpl::DoAutofill(WebCore::HTMLInputElement* input_element,
                                   bool autofill_on_empty_value,
                                   bool backspace) {
   std::wstring value = webkit_glue::StringToStdWString(input_element->value());
 
   // Only autofill when there is some text and the caret is at the end.
   bool caret_at_end =
       input_element->selectionStart() == input_element->selectionEnd() &&
@@ skipping 192 matching lines @@
   }
   return L"(UNKNOWN AFFINITY)";
 }
 
 std::wstring EditorClientImpl::Describe(WebCore::CSSStyleDeclaration* style) {
   // TODO(pamg): Implement me.  It's not clear what WebKit produces for this
   // (their [style description] method), and none of the layout tests provide
   // an example.  But because none of them use it, it's not yet important.
   return std::wstring();
 }