components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h - Issue 530153002: Add build and patch to Chrome-Proxy header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h

Issue 530153002: Add build and patch to Chrome-Proxy header (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: using "" instead of string Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc ('K') | « chrome/chrome_tests_unit.gypi ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h

diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h b/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h

index 992b8b66e5e5d04435c02800d18ec686866f2c43..4715b55d3792b5a73e55e35e794f581958f0772d 100644

--- a/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h

+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h

@@ -40,7 +40,8 @@ class DataReductionProxyAuthRequestHandler {

DataReductionProxyAuthRequestHandler(

const std::string& client,

- const std::string& version,

+ const std::string& build_number,

bengr 2014/09/03 22:28:39 Why can't this just take a version and do the spli

+ const std::string& patch_number,

DataReductionProxyParams* params,

scoped_refptr<base::SingleThreadTaskRunner> network_task_runner);

@@ -102,7 +103,8 @@ class DataReductionProxyAuthRequestHandler {

// Name of the client and version of the data reduction proxy protocol to use.

// Both live on the IO thread.

std::string client_;

- std::string version_;

+ std::string build_number_;

+ std::string patch_number_;

// The last time the session was updated. Used to ensure that a session is

// never used for more than twenty-four hours.