Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1501)

Unified Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h

Issue 530153002: Add build and patch to Chrome-Proxy header (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: using "" instead of string Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h
diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h
index 72f502680d8ed233185194e99def581fad7c3de3..945d1b4bec01510f8ee62fac03c922454786aaa9 100644
--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h
+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h
@@ -46,19 +46,37 @@ class DataReductionProxyChromeSettings
PrefService* local_state_prefs,
net::URLRequestContextGetter* request_context);
- // Using the chrome::VersionInfo version, returns the build and patch portion
- // of the string delimited by a period. If the chrome::VersionInfo version
- // isn't of the form xx.xx.xx.xx returns an empty string.
- static std::string GetBuildAndPatchNumber();
+ // Using the chrome::VersionInfo version, returns the build number of the
+ // chrome version. If the chrome::VersionInfo version isn't of the form
+ // xx.xx.xx.xx returns an empty string.
+ static std::string GetBuildNumber();
+
+ // Using the chrome::VersionInfo version, returns the patch number of the
+ // chrome version. If the chrome::VersionInfo version isn't of the form
+ // xx.xx.xx.xx returns an empty string.
+ static std::string GetPatchNumber();
// Gets the client type for the data reduction proxy.
static std::string GetClient();
private:
+ FRIEND_TEST_ALL_PREFIXES(DataReductionProxyChromeSettingsTest,
+ TestGetBuildNumber);
+ FRIEND_TEST_ALL_PREFIXES(DataReductionProxyChromeSettingsTest,
+ TestGetPatchNumber);
+
// Registers the DataReductionProxyEnabled synthetic field trial with
// the group |data_reduction_proxy_enabled|.
void RegisterSyntheticFieldTrial(bool data_reduction_proxy_enabled);
+ // Using |version|, returns the build number of the string. If |version|
+ // isn't of the form xx.xx.xx.xx returns an empty string.
+ static std::string GetBuildNumberFromString(std::string version);
+
+ // Using |version|, returns the patch number of the string. If |version|
+ // isn't of the form xx.xx.xx.xx returns an empty string.
+ static std::string GetPatchNumberFromString(std::string version);
+
DISALLOW_COPY_AND_ASSIGN(DataReductionProxyChromeSettings);
};

Powered by Google App Engine
This is Rietveld 408576698