Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1686)

Unified Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc

Issue 530153002: Add build and patch to Chrome-Proxy header (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc
diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc
index 26be2de2cd7dc939dba07a2f3d4b57d189009c0c..36a88113032f8ab29099812711d336b39a118dd1 100644
--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc
+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc
@@ -56,11 +56,17 @@ void DataReductionProxyChromeSettings::RegisterSyntheticFieldTrial(
// static
std::string DataReductionProxyChromeSettings::GetBuildAndPatchNumber() {
chrome::VersionInfo version_info;
+ return GetBuildAndPatchNumberFromString(version_info.Version());
+}
+
+// static
+std::string DataReductionProxyChromeSettings::GetBuildAndPatchNumberFromString(
+ std::string version) {
std::vector<std::string> version_parts;
- base::SplitString(version_info.Version(), '.', &version_parts);
+ base::SplitString(version, '.', &version_parts);
if (version_parts.size() != 4)
return "";
bengr 2014/09/02 22:57:53 return std::string();
megjablon 2014/09/02 23:11:28 Done.
- return version_parts[2] + version_parts[3];
+ return version_parts[2] + '.' + version_parts[3];
}
// static

Powered by Google App Engine
This is Rietveld 408576698