Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Side by Side Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h

Issue 530153002: Add build and patch to Chrome-Proxy header (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed bengr comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_ 5 #ifndef CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_
6 #define CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_ 6 #define CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "components/data_reduction_proxy/browser/data_reduction_proxy_settings. h" 9 #include "components/data_reduction_proxy/browser/data_reduction_proxy_settings. h"
10 #include "components/keyed_service/core/keyed_service.h" 10 #include "components/keyed_service/core/keyed_service.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 // Using the chrome::VersionInfo version, returns the build and patch portion 49 // Using the chrome::VersionInfo version, returns the build and patch portion
50 // of the string delimited by a period. If the chrome::VersionInfo version 50 // of the string delimited by a period. If the chrome::VersionInfo version
51 // isn't of the form xx.xx.xx.xx returns an empty string. 51 // isn't of the form xx.xx.xx.xx returns an empty string.
52 static std::string GetBuildAndPatchNumber(); 52 static std::string GetBuildAndPatchNumber();
53 53
54 // Gets the client type for the data reduction proxy. 54 // Gets the client type for the data reduction proxy.
55 static std::string GetClient(); 55 static std::string GetClient();
56 56
57 private: 57 private:
58 FRIEND_TEST_ALL_PREFIXES(DataReductionProxyChromeSettingsTest,
59 TestGetBuildAndPatchNumber);
60
58 // Registers the DataReductionProxyEnabled synthetic field trial with 61 // Registers the DataReductionProxyEnabled synthetic field trial with
59 // the group |data_reduction_proxy_enabled|. 62 // the group |data_reduction_proxy_enabled|.
60 void RegisterSyntheticFieldTrial(bool data_reduction_proxy_enabled); 63 void RegisterSyntheticFieldTrial(bool data_reduction_proxy_enabled);
61 64
65 // Using |version|, returns the build and patch portion of the string
66 // delimited by a period. If |version| isn't of the form xx.xx.xx.xx returns
67 // an empty string.
68 static std::string GetBuildAndPatchNumberFromString(std::string version);
69
62 DISALLOW_COPY_AND_ASSIGN(DataReductionProxyChromeSettings); 70 DISALLOW_COPY_AND_ASSIGN(DataReductionProxyChromeSettings);
63 }; 71 };
64 72
65 #endif // CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_ 73 #endif // CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698