Makes sure telemetry test result report is one string (no interreuption)

Makes sure telemetry test result report is one string (no interruption)

Otherwise there could be logging inserted between [ OK ] and the test name,
and the harness will fail to recognize the test is passing, raising false alarm.

BUG=409968
TEST=telemetry tests
R=bajones@chromium.org,tonyg@chromium.org
NOTRY=true

Committed: https://crrev.com/95aa6b1a1548d7dd670399e3b7c8aaa2904c47a2
Cr-Commit-Position: refs/heads/master@{#293031}

[Zhenyao Mo, 2014-09-02 20:10:16]

Please review.

[Ken Russell (switch to Gerrit), 2014-09-02 20:34:09]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2014-09-02 20:34:10]

LGTM

Let's please get this in ASAP so we can continue to keep the logging turned on.

[bajones, 2014-09-02 20:36:44]

lgtm

[Ken Russell (switch to Gerrit), 2014-09-02 20:40:04]

kbr@chromium.org changed reviewers:
+ chrishenry@google.com, ernstm@chromium.org, nednguyen@google.com

[Ken Russell (switch to Gerrit), 2014-09-02 20:40:04]

+more OWNERS. OWNERS review please, ASAP appreciated.

[chrishenry, 2014-09-02 20:44:14]

https://codereview.chromium.org/530143002/diff/1/tools/telemetry/telemetry/re...
File tools/telemetry/telemetry/results/gtest_progress_reporter.py (right):

https://codereview.chromium.org/530143002/diff/1/tools/telemetry/telemetry/re...
tools/telemetry/telemetry/results/gtest_progress_reporter.py:41: print >>
self._output_stream, '[ RUN      ]%s' % (
Can you run the unittest? I'm pretty sure there used to be a space between ] and
page display name, similarly for everything below.

./tools/telemetry/run_tests gtest_progress_reporter

[Zhenyao Mo, 2014-09-02 20:51:14]

Revised.  Thanks for catching the difference.  Please take another look.

https://codereview.chromium.org/530143002/diff/1/tools/telemetry/telemetry/re...
File tools/telemetry/telemetry/results/gtest_progress_reporter.py (right):

https://codereview.chromium.org/530143002/diff/1/tools/telemetry/telemetry/re...
tools/telemetry/telemetry/results/gtest_progress_reporter.py:41: print >>
self._output_stream, '[ RUN      ]%s' % (
On 2014/09/02 20:44:14, chrishenry wrote:
> Can you run the unittest? I'm pretty sure there used to be a space between ]
and
> page display name, similarly for everything below.
> 
> ./tools/telemetry/run_tests gtest_progress_reporter

Done.

[tonyg, 2014-09-02 21:21:15]

lgtm

Nice find! Feel free to land as-is, but it I can't help but notice this is a
little brittle. Any ideas for stopping the next refactor from breaking this
again? Is there a way to unittest? Or should we, at minimum, leave a comment?

[Zhenyao Mo, 2014-09-02 21:25:42]

On 2014/09/02 21:21:15, tonyg wrote:
> lgtm
> 
> Nice find! Feel free to land as-is, but it I can't help but notice this is a
> little brittle. Any ideas for stopping the next refactor from breaking this
> again? Is there a way to unittest? Or should we, at minimum, leave a comment?

I'll add comments to all these print places for now.  Thanks.

[chrishenry, 2014-09-02 21:27:40]

lgtm

[Zhenyao Mo, 2014-09-02 21:35:22]

The CQ bit was checked by zmo@chromium.org

[nednguyen, 2014-09-02 21:37:52]

On 2014/09/02 21:27:40, chrishenry wrote:
> lgtm

Also maybe change print >> self._stdout, ...., ... to self._stdout.write(...). 

I think the real bug here is python print is not thread safe. I wonder whether
this fix is enough though.

[commit-bot: I haz the power, 2014-09-02 21:43:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zmo@chromium.org/530143002/40001

[Zhenyao Mo, 2014-09-02 21:45:55]

On 2014/09/02 21:37:52, nednguyen wrote:
> On 2014/09/02 21:27:40, chrishenry wrote:
> > lgtm
> 
> Also maybe change print >> self._stdout, ...., ... to self._stdout.write(...).

> 
> I think the real bug here is python print is not thread safe. I wonder whether
> this fix is enough though.

Even if it's not enough, it should minimize the failures we see on GPU bots.

Of course, for the long run, we should make test results reporting and
processing really robust.

[commit-bot: I haz the power, 2014-09-02 22:45:37]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[commit-bot: I haz the power, 2014-09-02 23:56:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-02 23:56:55]

Failed to commit the patch.

[Zhenyao Mo, 2014-09-03 00:16:14]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2014-09-03 00:27:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zmo@chromium.org/530143002/40001

[commit-bot: I haz the power, 2014-09-03 00:49:49]

Committed patchset #3 (id:40001) as 0594171194e2544b4670d672734de3cae9ab270d

[commit-bot: I haz the power, 2014-09-10 03:22:15]

Patchset 3 (id:??) landed as
https://crrev.com/95aa6b1a1548d7dd670399e3b7c8aaa2904c47a2
Cr-Commit-Position: refs/heads/master@{#293031}