Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 53007: Porting of unit tests in chrome/ (Closed)

Created:
11 years, 9 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
Dean McNamee
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Porting of unit tests in chrome/ - enable following tests on Linux: browser/net/resolve_proxy_msg_helper_unittest.cc browser/profile_manager_unittest.cc browser/sessions/tab_restore_service_unittest.cc common/time_format_unittest.cc - sync chrome.gyp - fix a bug in resolve_proxy_msg_helper_unittest that triggered a DCHECK on POSIX. It freed the WaitableEvent too early because Wait in dtor was effectively a noop because the event was already in signaled state from previous operations and a manual-reset flag was set. The fix was to put the WaitableEvent in automatic reset mode. - misc GCC-related cleanups http://crbug.com/9227 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12356

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -36 lines) Patch
M chrome/browser/net/resolve_proxy_msg_helper_unittest.cc View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/sessions/tab_restore_service_unittest.cc View 16 chunks +28 lines, -28 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/unit/unit_tests.scons View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
11 years, 9 months ago (2009-03-24 12:27:14 UTC) #1
Dean McNamee
11 years, 9 months ago (2009-03-24 12:31:21 UTC) #2
LG but I didn't understand this one change:

http://codereview.chromium.org/53007/diff/1/2
File chrome/browser/net/resolve_proxy_msg_helper_unittest.cc (right):

http://codereview.chromium.org/53007/diff/1/2#newcode137
Line 137: RunnerBridge() : io_thread_("io_thread"), done_(false, false) {
Was this just a bug?

Powered by Google App Engine
This is Rietveld 408576698