Chromium Code Reviews
DescriptionPorting of unit tests in chrome/
- enable following tests on Linux:
browser/net/resolve_proxy_msg_helper_unittest.cc
browser/profile_manager_unittest.cc
browser/sessions/tab_restore_service_unittest.cc
common/time_format_unittest.cc
- sync chrome.gyp
- fix a bug in resolve_proxy_msg_helper_unittest that triggered
a DCHECK on POSIX.
It freed the WaitableEvent too early because Wait in dtor
was effectively a noop because the event was already in signaled
state from previous operations and a manual-reset flag was set.
The fix was to put the WaitableEvent in automatic reset mode.
- misc GCC-related cleanups
http://crbug.com/9227
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12356
Patch Set 1 #
Total comments: 1
Messages
Total messages: 2 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||