<webview> cleanup: Change self = this to bind(this) in web_view.js

chrome/renderer/resources/extensions/web_view.js

Index: chrome/renderer/resources/extensions/web_view.js
diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js
index 3c8c0d8295828dbc645eaa6cdce561fff33eb3eb..40dd19f365e9fd91ed1fd32ce5256b13e323d0ef 100644
--- a/chrome/renderer/resources/extensions/web_view.js
+++ b/chrome/renderer/resources/extensions/web_view.js
@@ -449,7 +449,7 @@ WebViewInternal.prototype.setupWebViewSrcAttributeMutationObserver =
       this.handleWebviewAttributeMutation(

[lazyboy, 2014/09/02 22:57:27]

^^^

           mutation.attributeName, oldValue, newValue);
     }.bind(this));
-  });
+  }.bind(this));

[lazyboy, 2014/09/02 17:45:34]

This isn't necessary, are you doing this for consistency only?

[Fady Samuel, 2014/09/02 22:53:59]

Are you sure about that? If I don't bind this here, then the this I bound on the
inside is wrong?

[lazyboy, 2014/09/02 22:57:27]

I was confused by the whole diff being messed up in the export.
This should be necessary.
In your export ^^^, it shows we are already using
this.handleWebviewAttributeMutation... which is weird.

   var params = {
     attributes: true,
     attributeOldValue: true,
@@ -747,7 +747,7 @@ WebViewInternal.prototype.dispatchEvent = function(webViewEvent) {
  */
 WebViewInternal.prototype.setupEventProperty = function(eventName) {
   var propertyName = 'on' + eventName.toLowerCase();
-  Object.defineProperty(webviewNode, propertyName, {
+  Object.defineProperty(this.webviewNode, propertyName, {
     get: function() {
       return this.on[propertyName];
     }.bind(this),