<webview> cleanup: Change self = this to bind(this) in web_view.js

chrome/renderer/resources/extensions/web_view.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This module implements Webview (<webview>) as a custom element that wraps a
 // BrowserPlugin object element. The object element is hidden within
 // the shadow DOM of the Webview element.
 
 var DocumentNatives = requireNative('document_natives');
 var GuestViewInternal =
@@ skipping 426 matching lines @@
 
 /**
  * @private
  */
 WebViewInternal.prototype.setupWebViewSrcAttributeMutationObserver =
     function() {
   // The purpose of this mutation observer is to catch assignment to the src
   // attribute without any changes to its value. This is useful in the case
   // where the webview guest has crashed and navigating to the same address
   // spawns off a new process.
-  var self = this;
   this.srcAndPartitionObserver = new MutationObserver(function(mutations) {
     $Array.forEach(mutations, function(mutation) {
       var oldValue = mutation.oldValue;
-      var newValue = self.webviewNode.getAttribute(mutation.attributeName);
+      var newValue = this.webviewNode.getAttribute(mutation.attributeName);
       if (oldValue != newValue) {
         return;
       }
-      self.handleWebviewAttributeMutation(
+      this.handleWebviewAttributeMutation(
           mutation.attributeName, oldValue, newValue);
-    });
-  });
+    }.bind(this));
+  }.bind(this));
   var params = {
     attributes: true,
     attributeOldValue: true,
     attributeFilter: ['src', 'partition']
   };
   this.srcAndPartitionObserver.observe(this.webviewNode, params);
 };
 
 /**
  * @private
@@ skipping 280 matching lines @@
 WebViewInternal.prototype.dispatchEvent = function(webViewEvent) {
   return this.webviewNode.dispatchEvent(webViewEvent);
 };
 
 /**
  * Adds an 'on<event>' property on the webview, which can be used to set/unset
  * an event handler.
  */
 WebViewInternal.prototype.setupEventProperty = function(eventName) {
   var propertyName = 'on' + eventName.toLowerCase();
-  var self = this;
-  var webviewNode = this.webviewNode;
-  Object.defineProperty(webviewNode, propertyName, {
+  Object.defineProperty(this.webviewNode, propertyName, {
     get: function() {
-      return self.on[propertyName];
-    },
+      return this.on[propertyName];
+    }.bind(this),
     set: function(value) {
-      if (self.on[propertyName])
-        webviewNode.removeEventListener(eventName, self.on[propertyName]);
-      self.on[propertyName] = value;
+      if (this.on[propertyName])
+        this.webviewNode.removeEventListener(eventName, self.on[propertyName]);
+      this.on[propertyName] = value;
       if (value)
-        webviewNode.addEventListener(eventName, value);
-    },
+        this.webviewNode.addEventListener(eventName, value);
+    }.bind(this),
     enumerable: true
   });
 };
 
 // Updates state upon loadcommit.
 WebViewInternal.prototype.onLoadCommit = function(
     currentEntryIndex, entryCount, processId, url, isTopLevel) {
   this.currentEntryIndex = currentEntryIndex;
   this.entryCount = entryCount;
   this.processId = processId;
@@ skipping 260 matching lines @@
 };
 
 /**
  * Implemented when the experimental API is available.
  * @private
  */
 WebViewInternal.prototype.setupExperimentalContextMenus = function() {};
 
 exports.WebView = WebView;
 exports.WebViewInternal = WebViewInternal;