<webview> cleanup: Change self = this to bind(this) in web_view.js

chrome/renderer/resources/extensions/web_view.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This module implements Webview (<webview>) as a custom element that wraps a
 // BrowserPlugin object element. The object element is hidden within
 // the shadow DOM of the Webview element.
 
 var DocumentNatives = requireNative('document_natives');
 var GuestViewInternal =
@@ skipping 428 matching lines @@
   // attribute without any changes to its value. This is useful in the case
   // where the webview guest has crashed and navigating to the same address
   // spawns off a new process.
   this.srcAndPartitionObserver = new MutationObserver(function(mutations) {
     $Array.forEach(mutations, function(mutation) {
       var oldValue = mutation.oldValue;
       var newValue = this.webviewNode.getAttribute(mutation.attributeName);
       if (oldValue != newValue) {
         return;
       }
       this.handleWebviewAttributeMutation(

[lazyboy, 2014/09/02 22:57:27]

^^^

           mutation.attributeName, oldValue, newValue);
     }.bind(this));
-  });
+  }.bind(this));

[lazyboy, 2014/09/02 17:45:34]

This isn't necessary, are you doing this for consistency only?

[Fady Samuel, 2014/09/02 22:53:59]

Are you sure about that? If I don't bind this here, then the this I bound on the
inside is wrong?

[lazyboy, 2014/09/02 22:57:27]

I was confused by the whole diff being messed up in the export.
This should be necessary.
In your export ^^^, it shows we are already using
this.handleWebviewAttributeMutation... which is weird.

   var params = {
     attributes: true,
     attributeOldValue: true,
     attributeFilter: ['src', 'partition']
   };
   this.srcAndPartitionObserver.observe(this.webviewNode, params);
 };
 
 /**
  * @private
@@ skipping 277 matching lines @@
 WebViewInternal.prototype.dispatchEvent = function(webViewEvent) {
   return this.webviewNode.dispatchEvent(webViewEvent);
 };
 
 /**
  * Adds an 'on<event>' property on the webview, which can be used to set/unset
  * an event handler.
  */
 WebViewInternal.prototype.setupEventProperty = function(eventName) {
   var propertyName = 'on' + eventName.toLowerCase();
-  Object.defineProperty(webviewNode, propertyName, {
+  Object.defineProperty(this.webviewNode, propertyName, {
     get: function() {
       return this.on[propertyName];
     }.bind(this),
     set: function(value) {
       if (this.on[propertyName])
         this.webviewNode.removeEventListener(eventName, this.on[propertyName]);
       this.on[propertyName] = value;
       if (value)
         this.webviewNode.addEventListener(eventName, value);
     }.bind(this),
@@ skipping 270 matching lines @@
 };
 
 /**
  * Implemented when the experimental API is available.
  * @private
  */
 WebViewInternal.prototype.setupExperimentalContextMenus = function() {};
 
 exports.WebView = WebView;
 exports.WebViewInternal = WebViewInternal;