<webview> cleanup: Change self = this to bind(this) in web_view.js

<webview> cleanup: Change self = this to bind(this) in web_view.js

BUG=none

Committed: https://crrev.com/7ac82fd5dc61d36a89c7e13e25709ab7cb7ad5eb
Cr-Commit-Position: refs/heads/master@{#293053}

[Fady Samuel, 2014-09-02 17:31:10]

fsamuel@chromium.org changed reviewers:
+ lazyboy@chromium.org

[lazyboy, 2014-09-02 17:45:34]

lgtm

https://codereview.chromium.org/530043002/diff/1/chrome/renderer/resources/ex...
File chrome/renderer/resources/extensions/web_view.js (right):

https://codereview.chromium.org/530043002/diff/1/chrome/renderer/resources/ex...
chrome/renderer/resources/extensions/web_view.js:452: }.bind(this));
This isn't necessary, are you doing this for consistency only?

[Fady Samuel, 2014-09-02 22:53:59]

CQ'ing.

https://codereview.chromium.org/530043002/diff/1/chrome/renderer/resources/ex...
File chrome/renderer/resources/extensions/web_view.js (right):

https://codereview.chromium.org/530043002/diff/1/chrome/renderer/resources/ex...
chrome/renderer/resources/extensions/web_view.js:452: }.bind(this));
On 2014/09/02 17:45:34, lazyboy wrote:
> This isn't necessary, are you doing this for consistency only?

Are you sure about that? If I don't bind this here, then the this I bound on the
inside is wrong?

[Fady Samuel, 2014-09-02 22:54:02]

The CQ bit was checked by fsamuel@chromium.org

[lazyboy, 2014-09-02 22:57:27]

https://codereview.chromium.org/530043002/diff/1/chrome/renderer/resources/ex...
File chrome/renderer/resources/extensions/web_view.js (right):

https://codereview.chromium.org/530043002/diff/1/chrome/renderer/resources/ex...
chrome/renderer/resources/extensions/web_view.js:449:
this.handleWebviewAttributeMutation(
^^^

https://codereview.chromium.org/530043002/diff/1/chrome/renderer/resources/ex...
chrome/renderer/resources/extensions/web_view.js:452: }.bind(this));
On 2014/09/02 22:53:59, Fady Samuel wrote:
> On 2014/09/02 17:45:34, lazyboy wrote:
> > This isn't necessary, are you doing this for consistency only?
> 
> Are you sure about that? If I don't bind this here, then the this I bound on
the
> inside is wrong?

I was confused by the whole diff being messed up in the export.
This should be necessary.
In your export ^^^, it shows we are already using
this.handleWebviewAttributeMutation... which is weird.

[commit-bot: I haz the power, 2014-09-02 23:12:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fsamuel@chromium.org/530043002/20001

[commit-bot: I haz the power, 2014-09-03 02:26:44]

Committed patchset #2 (id:20001) as a0b51db4a3ecc510d8cf3dfc8ee9848e78f36b3c

[commit-bot: I haz the power, 2014-09-10 03:22:58]

Patchset 2 (id:??) landed as
https://crrev.com/7ac82fd5dc61d36a89c7e13e25709ab7cb7ad5eb
Cr-Commit-Position: refs/heads/master@{#293053}