Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 530003002: DevTools: [Documentation] Add syntax highlight for code examples (Closed)

Created:
6 years, 3 months ago by semeny
Modified:
6 years, 3 months ago
Reviewers:
vsevik, lushnikov, iliia
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@iliia-patch
Project:
blink
Visibility:
Public.

Description

DevTools: [Documentation] Add syntax highlight for code examples Drive-by fixes: 1) Move DOMSyntaxHighlighter to ui/ 2) Remove "CSS" from experiment name 3) Fix documentation for RegExp methods BUG=391593 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181468

Patch Set 1 #

Patch Set 2 : Correct variable name #

Patch Set 3 : Fix HTML examples syntax highlight #

Patch Set 4 : Fix documentation for RegExp methods #

Total comments: 4

Patch Set 5 : Rebase on new patch #

Total comments: 2

Patch Set 6 : Comments addressed #

Total comments: 6

Patch Set 7 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -104 lines) Patch
M Source/devtools/devtools.gypi View 2 chunks +1 line, -1 line 0 comments Download
M Source/devtools/front_end/common/Settings.js View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/documentation/DocumentationURLProvider.js View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M Source/devtools/front_end/documentation/DocumentationView.js View 1 2 3 4 5 6 2 chunks +9 lines, -0 lines 0 comments Download
D Source/devtools/front_end/elements/DOMSyntaxHighlighter.js View 1 chunk +0 lines, -99 lines 0 comments Download
M Source/devtools/front_end/elements/module.json View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/inspector.html View 1 chunk +1 line, -0 lines 0 comments Download
A + Source/devtools/front_end/ui/DOMSyntaxHighlighter.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
semeny
6 years, 3 months ago (2014-09-02 15:07:29 UTC) #2
lushnikov
https://codereview.chromium.org/530003002/diff/60001/Source/devtools/front_end/documentation/DocumentationView.js File Source/devtools/front_end/documentation/DocumentationView.js (right): https://codereview.chromium.org/530003002/diff/60001/Source/devtools/front_end/documentation/DocumentationView.js#newcode33 Source/devtools/front_end/documentation/DocumentationView.js:33: } semicolon https://codereview.chromium.org/530003002/diff/60001/Source/devtools/front_end/documentation/DocumentationView.js#newcode216 Source/devtools/front_end/documentation/DocumentationView.js:216: var syntaxHighlighter = new WebInspector.DOMSyntaxHighlighter(WebInspector.DocumentationView._languageToMimeType[examples[i].language], ...
6 years, 3 months ago (2014-09-03 15:10:25 UTC) #3
lushnikov
https://codereview.chromium.org/530003002/diff/80001/Source/devtools/front_end/documentation/DocumentationURLProvider.js File Source/devtools/front_end/documentation/DocumentationURLProvider.js (right): https://codereview.chromium.org/530003002/diff/80001/Source/devtools/front_end/documentation/DocumentationURLProvider.js#newcode236 Source/devtools/front_end/documentation/DocumentationURLProvider.js:236: var sourceName = itemPath.substring(0, lastSlashIndex + 1).replace(" ", "_"); ...
6 years, 3 months ago (2014-09-03 15:24:51 UTC) #6
semeny
https://codereview.chromium.org/530003002/diff/60001/Source/devtools/front_end/documentation/DocumentationView.js File Source/devtools/front_end/documentation/DocumentationView.js (right): https://codereview.chromium.org/530003002/diff/60001/Source/devtools/front_end/documentation/DocumentationView.js#newcode33 Source/devtools/front_end/documentation/DocumentationView.js:33: } On 2014/09/03 15:10:25, lushnikov wrote: > semicolon Done. ...
6 years, 3 months ago (2014-09-03 15:34:28 UTC) #7
lushnikov
https://codereview.chromium.org/530003002/diff/120001/Source/devtools/front_end/common/Settings.js File Source/devtools/front_end/common/Settings.js (left): https://codereview.chromium.org/530003002/diff/120001/Source/devtools/front_end/common/Settings.js#oldcode297 Source/devtools/front_end/common/Settings.js:297: this.documentation = this._createExperiment("documentation", "Documentation for JS and CSS", true); ...
6 years, 3 months ago (2014-09-04 12:27:25 UTC) #8
semeny
https://codereview.chromium.org/530003002/diff/120001/Source/devtools/front_end/common/Settings.js File Source/devtools/front_end/common/Settings.js (left): https://codereview.chromium.org/530003002/diff/120001/Source/devtools/front_end/common/Settings.js#oldcode297 Source/devtools/front_end/common/Settings.js:297: this.documentation = this._createExperiment("documentation", "Documentation for JS and CSS", true); ...
6 years, 3 months ago (2014-09-04 13:20:37 UTC) #9
lushnikov
lgtm
6 years, 3 months ago (2014-09-05 11:37:21 UTC) #10
vsevik
lgtm
6 years, 3 months ago (2014-09-05 11:48:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/semeny@google.com/530003002/140001
6 years, 3 months ago (2014-09-05 11:49:19 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-05 12:56:03 UTC) #14
Message was sent while issue was closed. 
Committed patchset #7 (id:140001) as 181468

Powered by Google App Engine
This is Rietveld 408576698