Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2675)

Unified Diff: chrome/browser/ui/zoom/zoom_controller_browsertest.cc

Issue 529993002: Use IsRenderViewLive() to test for SadTab in ZoomController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/zoom/zoom_controller_browsertest.cc
diff --git a/chrome/browser/ui/zoom/zoom_controller_browsertest.cc b/chrome/browser/ui/zoom/zoom_controller_browsertest.cc
index 1d44bcc9e476756b6710d261274b2bd8ac0b69e5..4b8b2c623be53039f103ec81c882efbb3a14cb4a 100644
--- a/chrome/browser/ui/zoom/zoom_controller_browsertest.cc
+++ b/chrome/browser/ui/zoom/zoom_controller_browsertest.cc
@@ -10,6 +10,7 @@
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/render_process_host.h"
+#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test_utils.h"
@@ -40,7 +41,7 @@ IN_PROC_BROWSER_TEST_F(ZoomControllerBrowserTest,
base::KillProcess(host->GetHandle(), 0, false);
crash_observer.Wait();
}
- EXPECT_FALSE(web_contents->GetRenderProcessHost()->HasConnection());
+ EXPECT_FALSE(web_contents->GetRenderViewHost()->IsRenderViewLive());
// The following attempt to change the zoom level for a crashed tab should
// fail.
« chrome/browser/ui/zoom/zoom_controller.cc ('K') | « chrome/browser/ui/zoom/zoom_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698