Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: LayoutTests/fast/dom/HTMLScriptElement/script-crossOrigin.html

Issue 529933002: Make 'crossOrigin' IDL attributes nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/dom/HTMLScriptElement/script-crossOrigin.html
diff --git a/LayoutTests/fast/dom/HTMLScriptElement/script-crossOrigin.html b/LayoutTests/fast/dom/HTMLScriptElement/script-crossOrigin.html
index daaf085b83d995e1a047e33603ecde00c5925dc7..f841630c117bd8802f628c8eabef7894dff7c332 100644
--- a/LayoutTests/fast/dom/HTMLScriptElement/script-crossOrigin.html
+++ b/LayoutTests/fast/dom/HTMLScriptElement/script-crossOrigin.html
@@ -4,15 +4,15 @@
description("This tests the handling of the script.crossOrigin attribute");
var script = document.createElement("script");
shouldBeTrue("'crossOrigin' in script");
-shouldBeEqualToString("script.crossOrigin", "");
+shouldBeNull("script.crossOrigin");
shouldBeEqualToString("script.setAttribute('crossorigin', ''); script.crossOrigin", "anonymous");
-shouldBeEqualToString("script.removeAttribute('crossorigin'); script.crossOrigin", "");
+shouldBeNull("script.removeAttribute('crossorigin'); script.crossOrigin");
shouldBeEqualToString("script.setAttribute('crossorigin', 'foo'); script.crossOrigin", "anonymous");
shouldBeEqualToString("script.setAttribute('crossorigin', 'ANONYMOUS'); script.crossOrigin", "anonymous");
shouldBeEqualToString("script.setAttribute('crossorigin', 'use-credentials'); script.crossOrigin", "use-credentials");
shouldBeEqualToString("script.crossOrigin = ''; script.getAttribute('crossorigin')", "");
shouldBeEqualToString("script.crossOrigin = 'foo'; script.getAttribute('crossorigin')", "foo");
-shouldBeEqualToString("script.crossOrigin = null; script.getAttribute('crossorigin')", "null");
+shouldBeFalse("script.crossOrigin = null; script.hasAttribute('crossorigin')");
shouldBeEqualToString("script.crossOrigin = 'ANONYMOUS'; script.getAttribute('crossorigin')", "ANONYMOUS");
shouldBeEqualToString("script.crossOrigin = 'use-credentials'; script.getAttribute('crossorigin')", "use-credentials");
</script>

Powered by Google App Engine
This is Rietveld 408576698