Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 529913003: DevTools: Fixed range of ports available for tethering (Closed)

Created:
6 years, 3 months ago by vkuzkokov
Modified:
6 years, 3 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fixed range of ports available for tethering 1024 is the first port that doesn't require priveleged access and 32767 is the last port that isn't used as ephemeral. BUG=409658 Committed: https://crrev.com/af400ab6c2f014cdfaf0dc44ecd8d2125a85321c Cr-Commit-Position: refs/heads/master@{#292912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/devtools/tethering_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vkuzkokov
6 years, 3 months ago (2014-09-02 11:34:03 UTC) #2
pfeldman
lgtm.
6 years, 3 months ago (2014-09-02 11:42:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/529913003/1
6 years, 3 months ago (2014-09-02 11:43:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 281e58cf717a578b51c2ba1f74a022ed04e06a95
6 years, 3 months ago (2014-09-02 12:41:57 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:18:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af400ab6c2f014cdfaf0dc44ecd8d2125a85321c
Cr-Commit-Position: refs/heads/master@{#292912}

Powered by Google App Engine
This is Rietveld 408576698