Issue 529893002: Fix representation change insertion for phis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 529893002: Fix representation change insertion for phis. (Closed)

Created:
6 years, 3 months ago by titzer

Modified:
6 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix representation change insertion for phis. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23590

Patch Set 1 #

Total comments: 2

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -6 lines)			Patch
	M	src/compiler/simplified-lowering.cc	View		2 chunks	+19 lines, -6 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/529893002/diff/1/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/529893002/diff/1/src/compiler/simplified-lowering.cc#newcode257 src/compiler/simplified-lowering.cc:257: int values = OperatorProperties::GetValueInputCount(node->op()); nit: Can we move ...

6 years, 3 months ago (2014-09-02 08:37:01 UTC) #2

titzer

Committed patchset #1 manually as 23590 (presubmit successful).

6 years, 3 months ago (2014-09-02 10:14:33 UTC) #3

titzer

6 years, 3 months ago (2014-09-02 10:14:58 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/529893002/diff/1/src/compiler/simplified-lowe...
File src/compiler/simplified-lowering.cc (right):

https://codereview.chromium.org/529893002/diff/1/src/compiler/simplified-lowe...
src/compiler/simplified-lowering.cc:257: int values =
OperatorProperties::GetValueInputCount(node->op());
On 2014/09/02 08:37:01, Michael Starzinger wrote:
> nit: Can we move the values into the condition (i.e. one line below). Having
it
> be decremented to zero in two exclusive conditions looks dangerous to me.

Done.

Expand Messages | Collapse Messages