Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 52983005: Change the test for installing on 64 bit system in install-build-deps.sh (Closed)

Created:
7 years, 1 month ago by pschmidt1
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Change the test for installing on 64 bit system in install-build-deps.sh I'm thinking that checking if /sbin/init is 64 bit would be good? R=mmoss@chromium.org, phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
install-build-deps.sh View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pschmidt1
7 years, 1 month ago (2013-10-31 01:29:23 UTC) #1
Paweł Hajdan Jr.
LGTM
7 years, 1 month ago (2013-10-31 01:48:18 UTC) #2
Michael Moss
Another option might be 'dpkg-architecture', but I don't know if there's a good reason to ...
7 years, 1 month ago (2013-10-31 02:41:17 UTC) #3
pschmidt1
7 years, 1 month ago (2013-10-31 15:15:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r232117 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698