Convert ExtensionProcessManager to BrowserContext, part 1

Convert ExtensionProcessManager to BrowserContext, part 1

Part of moving ExtensionProcessManager to src/extensions.
* Introduce more test coverage
* Convert most usage of Profile to BrowserContext
* Separate out "master" vs. incognito profiles/contexts
* Move switches into extensions/common/switches.h

BUG=313481
TEST=unit_tests ExtensionProcessManager* and browser_tests ExtensionProcessManager*
R=miket@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232456

[James Cook, 2013-10-31 21:24:11]

miket, PTAL - this is the test-introduction and mechanical part of this change

yoz, just FYI

[miket_OOO, 2013-10-31 23:04:53]

Good stuff! LGTM

https://codereview.chromium.org/52983004/diff/70001/chrome/browser/extensions...
File chrome/browser/extensions/chrome_extensions_browser_client.cc (right):

https://codereview.chromium.org/52983004/diff/70001/chrome/browser/extensions...
chrome/browser/extensions/chrome_extensions_browser_client.cc:50: return
static_cast<Profile*>(context)->GetOriginalProfile();
This is probably already covered by your "all the way down" TODO, but if you
want to be a stickler for getting rid of all your static_casts, you could
include an identical, greppable TODO at each cast point. Up to you, either's OK.

https://codereview.chromium.org/52983004/diff/70001/chrome/browser/extensions...
File chrome/browser/extensions/extension_process_manager.cc (right):

https://codereview.chromium.org/52983004/diff/70001/chrome/browser/extensions...
chrome/browser/extensions/extension_process_manager.cc:115: DVLOG(1) <<
"CreateBackgroundHostForExtensionLoad";
OK to keep, but did you mean this?

https://codereview.chromium.org/52983004/diff/70001/chrome/browser/extensions...
chrome/browser/extensions/extension_process_manager.cc:271: DVLOG(1) <<
"CreateViewHost";
same

https://codereview.chromium.org/52983004/diff/70001/extensions/browser/extens...
File extensions/browser/extensions_browser_client.h (right):

https://codereview.chromium.org/52983004/diff/70001/extensions/browser/extens...
extensions/browser/extensions_browser_client.h:32: // Returns true if |context|
has an off-the-record context associated with it.
thanks!

[James Cook, 2013-11-01 00:08:31]

https://codereview.chromium.org/52983004/diff/70001/chrome/browser/extensions...
File chrome/browser/extensions/chrome_extensions_browser_client.cc (right):

https://codereview.chromium.org/52983004/diff/70001/chrome/browser/extensions...
chrome/browser/extensions/chrome_extensions_browser_client.cc:50: return
static_cast<Profile*>(context)->GetOriginalProfile();
On 2013/10/31 23:04:53, miket wrote:
> This is probably already covered by your "all the way down" TODO, but if you
> want to be a stickler for getting rid of all your static_casts, you could
> include an identical, greppable TODO at each cast point. Up to you, either's
OK.

These casts have to stay, as do all the others in this file.
ChromeExtensionsBrowserClient's main purpose in life is to cast BrowserContext
back to Profile so we can ask Profile-specific questions.  We just need to get
rid of the casts in the stuff moving to src/extensions.

https://codereview.chromium.org/52983004/diff/70001/chrome/browser/extensions...
File chrome/browser/extensions/extension_process_manager.cc (right):

https://codereview.chromium.org/52983004/diff/70001/chrome/browser/extensions...
chrome/browser/extensions/extension_process_manager.cc:115: DVLOG(1) <<
"CreateBackgroundHostForExtensionLoad";
On 2013/10/31 23:04:53, miket wrote:
> OK to keep, but did you mean this?

Yeah, I need these DVLOG lines to keep working on the follow-up patch.  I'll
strip them when the conversion is done, but for now they don't hurt release
builds.

[commit-bot: I haz the power, 2013-11-01 00:19:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/52983004/70001

[commit-bot: I haz the power, 2013-11-01 04:05:00]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-11-01 05:20:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/52983004/360001

[commit-bot: I haz the power, 2013-11-01 07:51:33]

Retried try job too often on win_rel for step(s) content_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-01 15:44:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/52983004/360001

[commit-bot: I haz the power, 2013-11-01 19:33:35]

Retried try job too often on win_rel for step(s) content_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[James Cook, 2013-11-01 20:18:59]

Committed patchset #4 manually as r232456 (presubmit successful).

[James Cook, 2013-11-01 23:34:37]

On 2013/11/01 20:18:59, James Cook wrote:
> Committed patchset #4 manually as r232456 (presubmit successful).

Reverted as r232513 because the test I added failed on Win XP. I suspect this is
flake, but I don't want to add a flaky test.

[James Cook, 2013-11-04 18:37:01]

Relanding as https://codereview.chromium.org/57813003/