athena/home/home_card_gesture_manager.cc - Issue 529813002: Simplify HomeCardGestureManager::UpdateScrollState()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/home/home_card_gesture_manager.cc

Issue 529813002: Simplify HomeCardGestureManager::UpdateScrollState() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: athena/home/home_card_gesture_manager.cc

diff --git a/athena/home/home_card_gesture_manager.cc b/athena/home/home_card_gesture_manager.cc

index 5ed7803a07b1a38411aebbf2d573d78adbe2c885..f63a6bee20c452d215cfb014de915a67b23ec556 100644

--- a/athena/home/home_card_gesture_manager.cc

+++ b/athena/home/home_card_gesture_manager.cc

@@ -75,7 +75,7 @@ void HomeCardGestureManager::UpdateScrollState(const ui::GestureEvent& event) {

if (last_estimated_height_ <= kHomeCardMinimizedHeight) {

delegate_->OnGestureProgressed(

- last_state_, HomeCard::VISIBLE_MINIMIZED, 1.0f);

+ HomeCard::VISIBLE_BOTTOM, HomeCard::VISIBLE_MINIMIZED, 1.0f);

last_state_ = HomeCard::VISIBLE_MINIMIZED;

return;

}

« no previous file with comments | « athena/home/home_card_gesture_manager.h ('k') | athena/home/home_card_gesture_manager_unittest.cc » ('j') | athena/home/home_card_impl.cc » ('J')