Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 529773002: Minor-key-ify four stubs. (Closed)

Created:
6 years, 3 months ago by Yang
Modified:
6 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Minor-key-ify four stubs. - ICCompareStub - BinaryOpICStub - CompareNilICStub - VectorLoadStub R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23605

Patch Set 1 #

Patch Set 2 : fix some compilation issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -245 lines) Patch
M src/arm/code-stubs-arm.cc View 10 chunks +15 lines, -15 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 11 chunks +15 lines, -15 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/code-stubs.h View 14 chunks +85 lines, -87 lines 0 comments Download
M src/code-stubs.cc View 9 chunks +29 lines, -58 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 10 chunks +15 lines, -15 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/ic.cc View 5 chunks +19 lines, -23 lines 0 comments Download
M src/objects.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 10 chunks +15 lines, -15 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 3 months ago (2014-09-01 15:32:48 UTC) #1
mvstanton
lgtm
6 years, 3 months ago (2014-09-02 08:07:35 UTC) #2
Yang
6 years, 3 months ago (2014-09-02 11:51:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 23605 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698