Issue 529763002: Added shadow DOM support to chromedriver. atoms.cc and .h are generated from the selenium tree. I'l…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 529763002: Added shadow DOM support to chromedriver. atoms.cc and .h are generated from the selenium tree. I'l… (Closed)

Created:
6 years, 3 months ago by mcharsley

Modified:
6 years, 2 months ago

Reviewers:
samuong

CC:
chromium-reviews, stgao

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Added shadow DOM support to chromedriver. atoms.cc and .h are generated from the selenium tree. I'll need some help generating a cleaner, more minimal change to those files, but the included versions can be used to evaluate the patch. BUG= TEST= added some unit tests (beginning with testShadowDom) to chrome/test/chromedriver/test/run_py_tests.py R=samuong@chromium.org

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1091 lines, -521 lines)			Patch
M	chrome/test/chromedriver/client/webelement.py	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/test/chromedriver/js/call_function.js	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/test/chromedriver/js/focus.js	View	1 chunk	+19 lines, -1 line	0 comments	Download
M	chrome/test/chromedriver/test/run_py_tests.py	View	1 chunk	+92 lines, -0 lines	0 comments	Download
A	chrome/test/data/chromedriver/shadow_dom_test.html	View	1 chunk	+55 lines, -0 lines	0 comments	Download
M	third_party/webdriver/atoms.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	third_party/webdriver/atoms.cc	View	4 chunks	+918 lines, -516 lines	0 comments	Download