Move UMA Media.VideoTrackAdapter.FramesReceived to VideoCaptureController.

Move UMA Media.VideoTrackAdapter.FramesReceived to VideoCaptureController.
Before this cl, VideoTrackAdapter.FramesReceived was logged for all types of MediaStreamVideoSources including remote video sources and pepper api sources.
The indent of this UMA stat is to track if a video capture device output video frames or not.

BUG=409624
Committed: https://crrev.com/0201e3f20d83a027b190c460ba616bf702fa0981
Cr-Commit-Position: refs/heads/master@{#293460}

[perkj_chrome, 2014-09-01 13:56:10]

perkj@chromium.org changed reviewers:
+ grunell@chromium.org, mcasas@chromium.org

[perkj_chrome, 2014-09-01 13:56:11]

Hej- can you please review?
Henrik, can you suggest an owner for Histograms.xml?

[Henrik Grunell, 2014-09-02 06:36:24]

Looks good.

For reviewer of histogram.xml - just pick any owner.

https://codereview.chromium.org/529733002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/media/video_capture_controller.cc (right):

https://codereview.chromium.org/529733002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/media/video_capture_controller.cc:554:
UMA_HISTOGRAM_BOOLEAN("Media.VideoCapture.FramesReceived", frame_received_);
Is there cases where we won't destruct this? How often would that happen?

I also wonder if started and stopped immediately after is likely to give any
frames? Do you know?

[mcasas, 2014-09-02 08:21:25]

lgtm

[perkj_chrome, 2014-09-02 08:30:27]

perkj@chromium.org changed reviewers:
+ isherman@chromium.org

[perkj_chrome, 2014-09-02 08:30:28]

Can you please take look?

https://codereview.chromium.org/529733002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/media/video_capture_controller.cc (right):

https://codereview.chromium.org/529733002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/media/video_capture_controller.cc:554:
UMA_HISTOGRAM_BOOLEAN("Media.VideoCapture.FramesReceived", frame_received_);
On 2014/09/02 06:36:23, Henrik Grunell wrote:
> Is there cases where we won't destruct this? How often would that happen?
> 
> I also wonder if started and stopped immediately after is likely to give any
> frames? Do you know?

To my knowledge, this object is destroyed when the capture device is stopped.

If you start the camera and immediately stop it, 0 frames are likely.

[Henrik Grunell, 2014-09-02 08:36:44]

lgtm

https://codereview.chromium.org/529733002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/media/video_capture_controller.cc (right):

https://codereview.chromium.org/529733002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/media/video_capture_controller.cc:554:
UMA_HISTOGRAM_BOOLEAN("Media.VideoCapture.FramesReceived", frame_received_);
On 2014/09/02 08:30:28, perkj wrote:
> On 2014/09/02 06:36:23, Henrik Grunell wrote:
> > Is there cases where we won't destruct this? How often would that happen?
> > 
> > I also wonder if started and stopped immediately after is likely to give any
> > frames? Do you know?
> 
> To my knowledge, this object is destroyed when the capture device is stopped.
> 
> If you start the camera and immediately stop it, 0 frames are likely. 

OK, we'll keep this in mind when interpreting the data.

[Ilya Sherman, 2014-09-02 20:11:30]

https://codereview.chromium.org/529733002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/529733002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:11752: -<histogram
name="Media.VideoTrackAdapter.FramesReceived" enum="BooleanReceived">
Please mark this histogram as <obsolete> rather than deleting it.

https://codereview.chromium.org/529733002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/529733002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:11684: +    If any frames were received
during a video capture session. It's recorded
nit: "If" -> "Whether"

https://codereview.chromium.org/529733002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:11684: +    If any frames were received
during a video capture session. It's recorded
nit: "It's" -> "This metric is"

[perkj_chrome, 2014-09-03 13:14:23]

PTAL

[Ilya Sherman, 2014-09-03 17:33:32]

Histograms LGTM, thanks.

[perkj_chrome, 2014-09-04 05:41:48]

The CQ bit was checked by perkj@chromium.org

[commit-bot: I haz the power, 2014-09-04 05:42:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/perkj@chromium.org/529733002/20001

[commit-bot: I haz the power, 2014-09-04 20:17:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-04 20:17:27]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[perkj_chrome, 2014-09-05 06:33:14]

The CQ bit was checked by perkj@chromium.org

[commit-bot: I haz the power, 2014-09-05 06:34:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/perkj@chromium.org/529733002/20001

[commit-bot: I haz the power, 2014-09-05 07:59:01]

Committed patchset #2 (id:20001) as fb9dd540bbe58335ec2a1e6ad4b2ba10c8bdb843

[commit-bot: I haz the power, 2014-09-10 03:37:31]

Patchset 2 (id:??) landed as
https://crrev.com/0201e3f20d83a027b190c460ba616bf702fa0981
Cr-Commit-Position: refs/heads/master@{#293460}