Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 52973003: mojo: break struct headers into headers and source (Closed)

Created:
7 years, 1 month ago by DaveMoore
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

mojo: break struct headers into headers and source BUG=None TEST=None R=darin@chromium.org, darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231954

Patch Set 1 #

Patch Set 2 : Add missing files #

Patch Set 3 : Add missing files #

Total comments: 1

Patch Set 4 : Add constant for header size #

Patch Set 5 : Add constant for header size #

Patch Set 6 : Add constant for header size #

Patch Set 7 : Add constant for header size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -109 lines) Patch
D mojo/public/bindings/generators/cpp_interface.template View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/public/bindings/generators/cpp_struct.template View 1 chunk +0 lines, -43 lines 0 comments Download
A mojo/public/bindings/generators/module_interface.h View 1 1 chunk +19 lines, -0 lines 0 comments Download
A mojo/public/bindings/generators/module_struct.h View 1 1 chunk +38 lines, -0 lines 0 comments Download
A mojo/public/bindings/generators/module_struct.cc View 1 1 chunk +19 lines, -0 lines 0 comments Download
M mojo/public/bindings/generators/mojom_cpp_generator.py View 1 2 3 7 chunks +83 lines, -42 lines 0 comments Download
M mojo/public/bindings/generators/run_cpp_generator.py View 1 chunk +2 lines, -2 lines 0 comments Download
mojo/public/bindings/mojo_idl.py View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
DaveMoore
Add missing files
7 years, 1 month ago (2013-10-30 22:33:28 UTC) #1
DaveMoore
Add missing files
7 years, 1 month ago (2013-10-30 22:38:32 UTC) #2
DaveMoore
7 years, 1 month ago (2013-10-30 22:38:50 UTC) #3
darin (slow to review)
LGTM https://codereview.chromium.org/52973003/diff/60001/mojo/public/bindings/generators/mojom_cpp_generator.py File mojo/public/bindings/generators/mojom_cpp_generator.py (right): https://codereview.chromium.org/52973003/diff/60001/mojo/public/bindings/generators/mojom_cpp_generator.py#newcode184 mojo/public/bindings/generators/mojom_cpp_generator.py:184: SIZE = size + 8, nit: might be ...
7 years, 1 month ago (2013-10-30 23:02:06 UTC) #4
DaveMoore
Add constant for header size
7 years, 1 month ago (2013-10-30 23:30:32 UTC) #5
DaveMoore
Add constant for header size
7 years, 1 month ago (2013-10-30 23:30:34 UTC) #6
DaveMoore
Add constant for header size
7 years, 1 month ago (2013-10-30 23:30:36 UTC) #7
DaveMoore
Add constant for header size
7 years, 1 month ago (2013-10-30 23:30:37 UTC) #8
DaveMoore
Add constant for header size
7 years, 1 month ago (2013-10-30 23:31:01 UTC) #9
DaveMoore
Add constant for header size
7 years, 1 month ago (2013-10-30 23:31:02 UTC) #10
DaveMoore
Add constant for header size
7 years, 1 month ago (2013-10-30 23:31:03 UTC) #11
DaveMoore
Add constant for header size
7 years, 1 month ago (2013-10-30 23:31:04 UTC) #12
DaveMoore
Add constant for header size
7 years, 1 month ago (2013-10-30 23:31:18 UTC) #13
DaveMoore
Add constant for header size
7 years, 1 month ago (2013-10-30 23:31:19 UTC) #14
DaveMoore
Add constant for header size
7 years, 1 month ago (2013-10-30 23:31:20 UTC) #15
DaveMoore
Add constant for header size
7 years, 1 month ago (2013-10-30 23:31:20 UTC) #16
DaveMoore
Add constant for header size
7 years, 1 month ago (2013-10-30 23:32:06 UTC) #17
DaveMoore
Add constant for header size
7 years, 1 month ago (2013-10-30 23:32:07 UTC) #18
DaveMoore
Add constant for header size
7 years, 1 month ago (2013-10-30 23:32:08 UTC) #19
DaveMoore
Add constant for header size
7 years, 1 month ago (2013-10-30 23:32:09 UTC) #20
DaveMoore
7 years, 1 month ago (2013-10-30 23:32:42 UTC) #21
Message was sent while issue was closed.
Committed patchset #7 manually as r231954 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698