Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Unified Diff: Source/core/inspector/PromiseTracker.h

Issue 529723002: [WIP] Protocol for sending information about Promises to frontend. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address review comments + add a simple test Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/PromiseTracker.h
diff --git a/Source/core/inspector/PromiseTracker.h b/Source/core/inspector/PromiseTracker.h
index ffb6bd475f33cd5f03efe12fe861a8243028a24b..c60ed8cc84186dc379bbb49e2fdd2de1e676f1b1 100644
--- a/Source/core/inspector/PromiseTracker.h
+++ b/Source/core/inspector/PromiseTracker.h
@@ -5,6 +5,7 @@
#ifndef PromiseTracker_h
#define PromiseTracker_h
+#include "core/InspectorTypeBuilder.h"
#include "wtf/HashMap.h"
#include "wtf/Noncopyable.h"
#include "wtf/RefPtr.h"
@@ -22,20 +23,25 @@ public:
~PromiseTracker();
bool isEnabled() const { return m_isEnabled; }
- void enable();
- void disable();
+ void setEnabled(bool = true);
aandrey 2014/09/02 14:34:49 drop "= true"
Alexandra Mikhaylova 2014/09/03 14:28:55 Done.
void clear();
void didReceiveV8PromiseEvent(ScriptState*, v8::Handle<v8::Object> promise, v8::Handle<v8::Value> parentPromise, int status);
+ PassRefPtr<TypeBuilder::Array<TypeBuilder::Debugger::PromiseDetails> > promises();
+
class PromiseData;
typedef Vector<RefPtr<PromiseData> > PromiseDataVector;
typedef HashMap<int, PromiseDataVector> PromiseDataMap;
private:
+ int circularSequentialId();
+ PassRefPtr<PromiseData> createPromiseDataIfNeeded(v8::Isolate*, v8::Handle<v8::Object> promise);
+
bool m_isEnabled;
+ int m_circularSequentialId;
PromiseDataMap m_promiseDataMap;
};

Powered by Google App Engine
This is Rietveld 408576698