Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 529693002: Set tabindex of search box -1 not to be focused by default. (Closed)

Created:
6 years, 3 months ago by fukino
Modified:
6 years, 3 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Set tabindex of search box -1 not to be focused by default. BUG=408949 TEST=manually Committed: https://crrev.com/6e873ef3ec639f9db3afd4d9082d51b49dc4c4df Cr-Commit-Position: refs/heads/master@{#292859}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/file_manager/file_manager/main.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
fukino
@yoshiki - could you take a look? This fix make the tab order same as ...
6 years, 3 months ago (2014-09-01 09:49:26 UTC) #2
yoshiki
LGTM
6 years, 3 months ago (2014-09-01 09:53:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/529693002/1
6 years, 3 months ago (2014-09-01 09:54:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as b49f58e73cb29063df285b90f6228bda0f1f7806
6 years, 3 months ago (2014-09-01 10:53:59 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:16:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e873ef3ec639f9db3afd4d9082d51b49dc4c4df
Cr-Commit-Position: refs/heads/master@{#292859}

Powered by Google App Engine
This is Rietveld 408576698