Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 52963002: rebaseline GM results on Android-IntelRhb and Valgrind bots which were not running for a while (Closed)

Created:
7 years, 1 month ago by epoger
Modified:
7 years, 1 month ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com, fmalita_google_do_not_use
Visibility:
Public.

Description

rebaseline GM results on Android-IntelRhb and Valgrind bots which were not running for a while Mostly tiny diffs due to roundrect implementation changes. Also a couple of GM tests that are known to have changed. Visually reviewed by bsalomon and epoger BUG=skia:1771 TBR=bsalomon Committed: https://code.google.com/p/skia/source/detail?r=12023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -555 lines) Patch
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json View 15 chunks +100 lines, -250 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Release/expected-results.json View 15 chunks +100 lines, -250 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-HD2000-x86_64-Release-Valgrind/expected-results.json View 6 chunks +22 lines, -55 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
Committed patchset #1 manually as r12023 (presubmit successful).
7 years, 1 month ago (2013-10-30 17:56:20 UTC) #1
epoger
committed TBR
7 years, 1 month ago (2013-10-30 17:56:44 UTC) #2
fmalita_google_do_not_use
On 2013/10/30 17:56:44, epoger wrote: > committed TBR Awesome, thanks for doing this! I was ...
7 years, 1 month ago (2013-10-30 18:02:23 UTC) #3
epoger
On 2013/10/30 18:02:23, fmalita wrote: > On 2013/10/30 17:56:44, epoger wrote: > > committed TBR ...
7 years, 1 month ago (2013-10-30 18:05:20 UTC) #4
bsalomon
7 years, 1 month ago (2013-10-31 15:39:14 UTC) #5
On 2013/10/30 18:05:20, epoger wrote:
> On 2013/10/30 18:02:23, fmalita wrote:
> > On 2013/10/30 17:56:44, epoger wrote:
> > > committed TBR
> > 
> > Awesome, thanks for doing this! I was about to shoot an IntelRhb GM code
> yellow
> > email for these failures - they sneaked in while the bots were down for more
> > than a week, so the blame-list is useless :)
> 
> You bet.  I filed a bunch of BreakingTheBuildbot issues for some of these
tests
> earlier today (https://code.google.com/p/skia/issues/detail?id=1774 , 1775,
> 1776, ...) and then I thought "man, there's too many, I'd better just carve
out
> a bunch at once".

lgtm

Powered by Google App Engine
This is Rietveld 408576698