Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tools/bisect-perf-regression.py

Issue 529593002: In the presubmit for auto-bisect, run pylint and unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/auto_bisect/ttest_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-perf-regression.py
diff --git a/tools/bisect-perf-regression.py b/tools/bisect-perf-regression.py
index 6e5aabff23968656dedc1e92c1ca77a97e789982..17805f4c752301bb4712ce3177906658395748ff 100755
--- a/tools/bisect-perf-regression.py
+++ b/tools/bisect-perf-regression.py
@@ -539,14 +539,14 @@ def _WaitUntilBuildIsReady(
last_status_check = time.time()
if not build_num:
# Get the build number on try server for the current build.
- build_num = bisect_builder.GetBuildNumFromBuilder(
+ build_num = request_build.GetBuildNumFromBuilder(
build_request_id, bot_name, builder_host, builder_port)
# Check the status of build using the build number.
# Note: Build is treated as PENDING if build number is not found
# on the the try server.
- build_status, status_link = bisect_builder.GetBuildStatus(
+ build_status, status_link = request_build.GetBuildStatus(
build_num, bot_name, builder_host, builder_port)
- if build_status == bisect_builder.FAILED:
+ if build_status == request_build.FAILED:
return (None, 'Failed to produce build, log: %s' % status_link)
elapsed_time = time.time() - start_time
if elapsed_time > max_timeout:
@@ -1369,7 +1369,7 @@ class BisectPerformanceMetrics(object):
if patch:
job_args['patch'] = patch
# Posts job to build the revision on the server.
- if bisect_builder.PostTryJob(builder_host, builder_port, job_args):
+ if request_build.PostTryJob(builder_host, builder_port, job_args):
target_file, error_msg = _WaitUntilBuildIsReady(
fetch_build, bot_name, builder_host, builder_port, build_request_id,
build_timeout)
« no previous file with comments | « tools/auto_bisect/ttest_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698