Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: tools/auto_bisect/builder.py

Issue 529593002: In the presubmit for auto-bisect, run pylint and unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/auto_bisect/PRESUBMIT.py ('k') | tools/auto_bisect/run_tests » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/auto_bisect/builder.py
diff --git a/tools/auto_bisect/builder.py b/tools/auto_bisect/builder.py
index c54f9fa1dadf17209606327a63e43a1f71a6bd1c..f039a57e5d988449cc9d4782ea0c9e51e90637a0 100644
--- a/tools/auto_bisect/builder.py
+++ b/tools/auto_bisect/builder.py
@@ -142,6 +142,9 @@ class AndroidBuilder(Builder):
def __init__(self, opts):
super(AndroidBuilder, self).__init__(opts)
+ # TODO(qyearsley): Make this a class method and verify that it works with
+ # a unit test.
+ # pylint: disable=R0201
def _GetTargets(self):
"""Returns a list of build targets."""
return ['chrome_shell_apk', 'cc_perftests_apk', 'android_tools']
@@ -179,6 +182,9 @@ class AndroidChromeBuilder(AndroidBuilder):
def __init__(self, opts):
super(AndroidChromeBuilder, self).__init__(opts)
+ # TODO(qyearsley): Make this a class method and verify that it works with
+ # a unit test.
+ # pylint: disable=R0201
def _GetTargets(self):
"""Returns a list of build targets."""
return AndroidBuilder._GetTargets(self) + ['chrome_apk']
« no previous file with comments | « tools/auto_bisect/PRESUBMIT.py ('k') | tools/auto_bisect/run_tests » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698