Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1732)

Unified Diff: tools/auto_bisect/PRESUBMIT.py

Issue 529593002: In the presubmit for auto-bisect, run pylint and unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/PRESUBMIT.py ('k') | tools/auto_bisect/builder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/auto_bisect/PRESUBMIT.py
diff --git a/tools/PRESUBMIT.py b/tools/auto_bisect/PRESUBMIT.py
similarity index 73%
rename from tools/PRESUBMIT.py
rename to tools/auto_bisect/PRESUBMIT.py
index e7b9b25faa8de33fe4437a365d011eabf094f741..20ea62f0d25916e8c20304d68ec957f04bbc6750 100644
--- a/tools/PRESUBMIT.py
+++ b/tools/auto_bisect/PRESUBMIT.py
@@ -5,10 +5,11 @@
"""Top-level presubmit script for auto-bisect.
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
-details on the presubmit API built into gcl.
+details on the presubmit API.
"""
import imp
+import subprocess
import os
# Paths to bisect config files relative to src/tools.
@@ -17,10 +18,6 @@ CONFIG_FILES = [
'run-perf-test.cfg'
]
-PYLINT_BLACKLIST = []
-PYLINT_DISABLED_WARNINGS = []
-
-
def CheckChangeOnUpload(input_api, output_api):
return _CommonChecks(input_api, output_api)
@@ -31,10 +28,10 @@ def CheckChangeOnCommit(input_api, output_api):
def _CommonChecks(input_api, output_api):
"""Does all presubmit checks for auto-bisect."""
- # TODO(qyearsley) Run bisect unit test.
- # TODO(qyearsley) Run pylint on all auto-bisect py files but not other files.
results = []
results.extend(_CheckAllConfigFiles(input_api, output_api))
+ results.extend(_RunUnitTests(input_api, output_api))
+ results.extend(_RunPyLint(input_api, output_api))
return results
@@ -64,7 +61,7 @@ def _CheckConfigFile(file_path, output_api):
warning = 'Config file "config" global variable is not dict: %s' % str(e)
return [output_api.PresubmitError(warning, items=[file_path])]
- for k, v in config_dict.iteritems():
+ for k, v in config_file.config.iteritems():
if v != '':
warning = 'Non-empty value in config dict: %s: %s' % (repr(k), repr(v))
warning += ('\nThe bisection config file should only contain a config '
@@ -73,3 +70,21 @@ def _CheckConfigFile(file_path, output_api):
return [output_api.PresubmitError(warning, items=[file_path])]
return []
+
+
+def _RunUnitTests(input_api, output_api):
+ """Runs unit tests for auto-bisect."""
+ repo_root = input_api.change.RepositoryRoot()
+ auto_bisect_dir = os.path.join(repo_root, 'tools', 'auto_bisect')
+ test_runner = os.path.join(auto_bisect_dir, 'run_tests')
+ return_code = subprocess.call(['python', test_runner])
+ if return_code:
+ message = 'Auto-bisect unit tests did not all pass.'
+ return [output_api.PresubmitError(message)]
+ return []
+
+
+def _RunPyLint(input_api, output_api):
+ """Runs unit tests for auto-bisect."""
+ tests = input_api.canned_checks.GetPylint(input_api, output_api)
+ return input_api.RunTests(tests)
« no previous file with comments | « tools/PRESUBMIT.py ('k') | tools/auto_bisect/builder.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698