Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 529593002: In the presubmit for auto-bisect, run pylint and unit tests. (Closed)

Created:
6 years, 3 months ago by qyearsley
Modified:
6 years, 3 months ago
Reviewers:
tonyg
CC:
chromium-reviews, prasadv
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

In the presubmit for auto-bisect, run pylint and unit tests. Note: This only runs pylint and tests for the auto_bisect directory (this was much simpler than picking and choosing particular files from the parent tools directory). I think the next step is to move bisect-perf-regression.py and related files into the auto_bisect directory. BUG= Committed: https://crrev.com/da5d7ad196c83ceefbd66b44178bba4ab9f29b98 Cr-Commit-Position: refs/heads/master@{#292833}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -87 lines) Patch
D tools/PRESUBMIT.py View 1 chunk +0 lines, -75 lines 0 comments Download
A + tools/auto_bisect/PRESUBMIT.py View 5 chunks +23 lines, -8 lines 0 comments Download
M tools/auto_bisect/builder.py View 2 chunks +6 lines, -0 lines 0 comments Download
A tools/auto_bisect/run_tests View 1 chunk +27 lines, -0 lines 0 comments Download
M tools/auto_bisect/source_control.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/auto_bisect/ttest_test.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/bisect-perf-regression.py View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
qyearsley
6 years, 3 months ago (2014-09-01 02:55:23 UTC) #2
tonyg
lgtm!! I think this is going to be a huge help, especially as unittest coverage ...
6 years, 3 months ago (2014-09-01 03:30:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qyearsley@chromium.org/529593002/20001
6 years, 3 months ago (2014-09-01 03:33:15 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4b15ea8f108f70747100da144beac089102b9073
6 years, 3 months ago (2014-09-01 04:28:11 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:15:34 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da5d7ad196c83ceefbd66b44178bba4ab9f29b98
Cr-Commit-Position: refs/heads/master@{#292833}

Powered by Google App Engine
This is Rietveld 408576698